Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update osmosis tests, using code id to predict addresses #528

Merged
merged 15 commits into from
Nov 15, 2024
Merged

Update osmosis tests, using code id to predict addresses #528

merged 15 commits into from
Nov 15, 2024

Conversation

Buckram123
Copy link
Collaborator

This PR aims to refactor predicting addresses to relying on creator of the code id instead of hardcoded values in wasms

@Buckram123
Squashed commit of the following:
893a51d 
commit c22c908
Merge: da4366d 0a301a1
Author: Buckram <[email protected]>
Date:   Wed Nov 6 16:29:41 2024 +0200

    Merge remote-tracking branch 'origin/main' into buckram/update-osmosis-tests-code-id-in-state

commit da4366d
Author: Buckram <[email protected]>
Date:   Wed Nov 6 16:27:28 2024 +0200

    update account instantiation

commit d86ee7e
Merge: 868f061 35046ee
Author: Buckram <[email protected]>
Date:   Wed Nov 6 15:57:49 2024 +0200

    Merge remote-tracking branch 'origin/main' into buckram/update-osmosis-tests-code-id-in-state

commit 868f061
Author: Buckram <[email protected]>
Date:   Wed Nov 6 14:16:58 2024 +0200

    update modules tests

commit 04552f9
Author: Buckram <[email protected]>
Date:   Wed Nov 6 13:27:34 2024 +0200

    framework tests pass

commit 26316dc
Author: Buckram <[email protected]>
Date:   Tue Nov 5 15:19:55 2024 +0200

    test fix init

commit 162c055
Author: Buckram <[email protected]>
Date:   Tue Nov 5 14:52:53 2024 +0200

    adapter changes

commit 19a2eeb
Author: Buckram <[email protected]>
Date:   Tue Nov 5 14:07:51 2024 +0200

    update uses

commit b4c94e9
Merge: 29975b3 1f496f9
Author: Buckram <[email protected]>
Date:   Tue Nov 5 10:36:09 2024 +0200

    Merge remote-tracking branch 'origin/main' into buckram/update-osmosis-tests-code-id-in-state

commit 29975b3
Author: Buckram <[email protected]>
Date:   Tue Nov 5 10:34:01 2024 +0200

    creator unknown until publish

commit f237470
Author: Buckram <[email protected]>
Date:   Fri Oct 25 15:46:20 2024 +0300

    remove patch section

commit afcb4a1
Merge: 69e620d 8a369b2
Author: Buckram <[email protected]>
Date:   Fri Oct 25 15:41:59 2024 +0300

    Merge remote-tracking branch 'origin/main' into buckram/update-osmosis-tests

commit 69e620d
Author: Buckram <[email protected]>
Date:   Thu Oct 24 18:58:56 2024 +0300

    mock-deployment for apps/adapters wasm

commit fef1b4d
Author: Buckram <[email protected]>
Date:   Thu Oct 24 15:51:59 2024 +0300

    update hakari

commit 016f9fc
Author: Buckram <[email protected]>
Date:   Thu Oct 24 15:43:03 2024 +0300

    unused dep

commit 18f3397
Author: Buckram <[email protected]>
Date:   Thu Oct 24 15:40:09 2024 +0300

    update osmosis tests
@Buckram123
update interchain tests
dc8a2ac
@Buckram123
clean ups
bf047a7
@Buckram123
Copy link
Collaborator Author

As a nice bonus this PR significantly decreases wasm sizes

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 6, 2024 •
edited
Loading

Deploying abstract-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 087de20
Status:⚡️  Build in progress...

View logs

Kayanski
Kayanski requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@Kayanski Kayanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very good thank you. Some remarks:

  • We can hide and potentially cache more thing from the users (for instance the contract info query that you do EVERYWHERE)
  • We need to discuss storing the creator address in a once-cell or something simiar

framework/Cargo.toml Outdated Show resolved Hide resolved
framework/contracts/account/src/modules.rs Outdated Show resolved Hide resolved
framework/contracts/account/src/queries.rs Outdated Show resolved Hide resolved
@Kayanski
Copy link
Contributor

Kayanski commented Nov 6, 2024

As a nice bonus this PR significantly decreases wasm sizes

Why though ? haha seems weird to me

@Buckram123
Copy link
Collaborator Author

As a nice bonus this PR significantly decreases wasm sizes

Why though ? haha seems weird to me

Bech32 generation quite expensive!

@codecov Codecov
Copy link

codecov bot commented Nov 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.15464% with 77 lines in your changes missing coverage. Please review.

Project coverage is 65.6%. Comparing base (bf989a9) to head (51599c6).
Report is 55 commits behind head on main.

Files with missing lines Patch % Lines
...les/contracts/adapters/money-market/src/adapter.rs 0.0% 12 Missing ⚠️
modules/contracts/adapters/dex/src/adapter.rs 0.0% 9 Missing ⚠️
...les/contracts/adapters/dex/src/handlers/execute.rs 0.0% 6 Missing ⚠️
...acts/adapters/money-market/src/handlers/execute.rs 0.0% 5 Missing ⚠️
...amework/contracts/native/ibc-client/src/queries.rs 0.0% 4 Missing ⚠️
...amework/packages/abstract-interface/src/account.rs 25.0% 3 Missing ⚠️
integrations/osmosis-adapter/src/dex.rs 0.0% 3 Missing ⚠️
...tracts/adapters/cw-staking/src/handlers/execute.rs 0.0% 3 Missing ⚠️
...tracts/adapters/money-market/src/handlers/query.rs 0.0% 3 Missing ⚠️
...les/contracts/apps/payment/src/handlers/execute.rs 0.0% 3 Missing ⚠️
... and 16 more
Additional details and impacted files
Files with missing lines Coverage Δ
framework/contracts/account/src/config.rs 95.0% <ø> (ø)
framework/contracts/account/src/contract.rs 84.1% <100.0%> (-5.5%) ⬇️
framework/contracts/account/src/execution.rs 76.4% <ø> (ø)
framework/contracts/account/src/lib.rs 100.0% <100.0%> (ø)
framework/contracts/account/src/migrate.rs 100.0% <ø> (ø)
framework/contracts/account/src/modules.rs 97.0% <100.0%> (+<0.1%) ⬆️
...amework/contracts/account/src/modules/migration.rs 95.7% <100.0%> (+<0.1%) ⬆️
framework/contracts/account/src/queries.rs 99.2% <100.0%> (+<0.1%) ⬆️
framework/contracts/account/src/sub_account.rs 98.3% <100.0%> (+<0.1%) ⬆️
...mework/contracts/native/ibc-client/src/commands.rs 93.9% <100.0%> (-0.2%) ⬇️
... and 75 more

... and 86 files with indirect coverage changes

@Kayanski
Copy link
Contributor

Is this branch now closing
#512
and
#518
?

@Buckram123 Buckram123 mentioned this pull request Nov 11, 2024
Closed
@Buckram123 Buckram123 mentioned this pull request Nov 11, 2024
Closed
Kayanski
Kayanski approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@Kayanski Kayanski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wonderful.
We need to bump to 0.25 version though as this is VERY breaking

@Buckram123
Copy link
Collaborator Author

This is wonderful. We need to bump to 0.25 version though as this is VERY breaking

Should we hold a bit and merge it when we ready for 0.25 release, in case there will be more 0.24.x patches?

@Kayanski
Copy link
Contributor

This is wonderful. We need to bump to 0.25 version though as this is VERY breaking

Should we hold a bit and merge it when we ready for 0.25 release, in case there will be more 0.24.x patches?

Yes ! This is not pressing for testnet

@Buckram123 Buckram123 merged commit 95c055a into main Nov 15, 2024
16 of 22 checks passed
@Buckram123 Buckram123 deleted the buckram/update-osmosis-tests-code-id-squashed branch November 15, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kayanski Kayanski Kayanski approved these changes

Assignees
No one assigned
Labels
account adapter_base app_base breaking CI interface native sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Buckram123 @Kayanski