Update osmosis tests #512
Closed
Update osmosis tests #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying abstract-docs with
|
| Latest commit: |
f237470
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b6f398ed.abstract-docs.pages.dev |
| Branch Preview URL: | https://buckram-update-osmosis-tests.abstract-docs.pages.dev |
|
Depends on AbstractSDK/cw-orchestrator#511 |
Buckram123
commented
Oct 25, 2024
Comment on lines
219
to
236
| for $interface_name<Chain> | ||
| { | ||
| fn wasm(_chain: &::cw_orch::prelude::ChainInfoOwned) -> ::cw_orch::prelude::WasmPath { | ||
| let build_postfix = { | ||
| #[cfg(feature = "mock-deployment")] | ||
| { | ||
| cw_orch::build::BuildPostfix::Custom("mock".to_string()) | ||
| } | ||
| #[cfg(not(feature = "mock-deployment"))] | ||
| { | ||
| cw_orch::build::BuildPostfix::None | ||
| } | ||
| }; | ||
| let wasm_name = env!("CARGO_CRATE_NAME").replace('-', "_"); | ||
| ::cw_orch::prelude::ArtifactsDir::auto(Some(env!("CARGO_MANIFEST_DIR").to_string())) | ||
| .find_wasm_path(&wasm_name) | ||
| .find_wasm_path_with_build_postfix(&wasm_name, build_postfix) | ||
| .unwrap() | ||
| } |
There was a problem hiding this comment.
Not sure about this one, but I don't know how to solve it better in current implementation.
Issue that it will require the module to have exactly module-deployment feature. This issue comes out because we generate this code with macro and feature checks is happening after macro gets evaluated inside user crate, and not on abstract-app level
There was a problem hiding this comment.
@Buckram123 so this will be removed with the new solution right?
There was a problem hiding this comment.
@Buckram123 so this will be removed with the new solution right?
Drafting this PR for now. But yes, hopefully all magic would be limited in a build script
|
Closed in favor #528 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that osmosis and test-tube updated to cosmwasm v2 we can enable integration and tests back
This PR introduces mock binaries and
mock-deployfeature with open mnemonic to the abstract, it allows publishing abstract in a mocked chains: local, test tubes or starship