Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[auto] Extension dependencies are also installed for disabled extensions #563

Closed
2 tasks done
DevilaN opened this issue Jul 31, 2023 · 2 comments · Fixed by #582
Closed
2 tasks done

[auto] Extension dependencies are also installed for disabled extensions #563

DevilaN opened this issue Jul 31, 2023 · 2 comments · Fixed by #582
Labels
awaiting-response Waiting for the issuer to respond bug Something isn't working

Comments

@DevilaN
Copy link
Contributor

DevilaN commented Jul 31, 2023

Has this issue been opened before?

  • It is not in the FAQ, I checked.
  • It is not in the issues, I searched.

Describe the bug

Entrypoint for auto installs dependencies for all existing extensions on disk not checking whether it is enabled.
My cat is left intact.

Which UI

auto or auto-cpu

Hardware / Software

Potato on steroids.

Steps to Reproduce

  1. Install any extension that has dependencies inside @install.py@ file.
  2. Disable that extension in webui.
  3. Restart container.
  4. See dependency installation info for that very extension being processed.

Additional context

Following code in services/AUTOMATIC1111/entrypoint.sh file is reason for such behavior:

# For install.py, please refer to https://github.com/AUTOMATIC1111/stable-diffusion-webui/wiki/Developing-extensions#installpy
list=(./extensions/*/install.py)
for installscript in "${list[@]}"; do
  PYTHONPATH=${ROOT} python "$installscript"
done

I propose something like this to resolve if extension is enabled by using info in config.json file:

EXTNAME=`echo $installscript | cut -d '/' -f 3`
if ! `jq -e ".disabled_extensions|any(. == \"$EXTNAME\")" config.json`; then
  PYTHONPATH=${ROOT} python "$installscript"
fi
@DevilaN DevilaN added the bug Something isn't working label Jul 31, 2023
@AbdBarho
Copy link
Owner

AbdBarho commented Aug 6, 2023

Sounds good! I have not disabled any extensions before, I usually just delete.
Would you like to create a PR?

@AbdBarho AbdBarho added the awaiting-response Waiting for the issuer to respond label Aug 26, 2023
DevilaN added a commit to DevilaN/stable-diffusion-webui-docker that referenced this issue Sep 4, 2023
@DevilaN
Copy link
Contributor Author

DevilaN commented Sep 4, 2023

Done

torun225 added a commit to torun225/stable-diffusion-webui-docker that referenced this issue Aug 2, 2024
commit 3e67f55
Author: AbdBarho <[email protected]>
Date:   Mon Nov 13 21:12:07 2023 +0100

    Update Auto (AbdBarho#610)

    Closes AbdBarho#609

    AUTOMATIC1111/stable-diffusion-webui@4afaaf8

commit a2561f2
Author: cococig <[email protected]>
Date:   Tue Nov 14 03:35:24 2023 +0900

    Update automatic1111 webui base image (AbdBarho#601)

    Update the minor version of Python in the base image for AUTOMATIC1111
    web UI.

    Closes issue AbdBarho#600

commit 6a34739
Author: cloudaxes <[email protected]>
Date:   Sat Sep 9 23:10:05 2023 +0900

    Update Automatic1111 to v1.6.0 (AbdBarho#585)

    Update Automatic1111 Stable Diffusion Webui to v1.6.0.

    Closes AbdBarho#583

    ---------

    Co-authored-by: AbdBarho <[email protected]>

commit 630980b
Author: Sebastian Piechowiak <[email protected]>
Date:   Sat Sep 9 15:34:06 2023 +0200

    Skipping installation of requirements for disabled extensions (AbdBarho#582)

    Closes AbdBarho#563

commit 8474059
Author: 66li <[email protected]>
Date:   Fri Sep 1 02:04:32 2023 +0800

    Update generative-models version (AbdBarho#581)

    Upgrade a dependent library

    https://github.com/AUTOMATIC1111/stable-diffusion-webui/blob/v1.5.2/modules/launch_utils.py#L288C90-L288C130

    ---------

    Co-authored-by: AbdBarho <[email protected]>

commit 59b9762
Author: AbdBarho <[email protected]>
Date:   Wed Aug 30 20:00:48 2023 +0200

    Update Comfy (AbdBarho#580)

    comfyanonymous/ComfyUI@7e941f9

commit 70357bf
Author: AbdBarho <[email protected]>
Date:   Wed Aug 30 19:55:06 2023 +0200

    Auto 1.5.2 (AbdBarho#579)

    AUTOMATIC1111/stable-diffusion-webui@c9c8485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-response Waiting for the issuer to respond bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants