Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/508 change variable in StorageUnit from long int to int64_t #509

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

LorenzzoQM
Copy link
Contributor

  • Tickets addressed: bsk-508
  • Review: By commit
  • Merge strategy: Merge (no squash)

Description

Variable types long long int were updated to int64_t to guarantee the same size of integers across platforms.

Verification

Current unit tests are still valid after the changes.

Documentation

N/A

Future work

N/A

@LorenzzoQM LorenzzoQM self-assigned this Nov 24, 2023
@LorenzzoQM LorenzzoQM linked an issue Nov 24, 2023 that may be closed by this pull request
@schaubh schaubh added the enhancement New feature or request label Nov 25, 2023
@LorenzzoQM LorenzzoQM force-pushed the refactor/508_storageUnit_longint_to_int64 branch from 2c5280d to 67a73d3 Compare November 27, 2023 16:59
@LorenzzoQM LorenzzoQM force-pushed the refactor/508_storageUnit_longint_to_int64 branch from 67a73d3 to 7ebba12 Compare November 27, 2023 17:00
Copy link
Contributor

@schaubh schaubh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.

@patkenneally
Copy link
Contributor

@LorenzzoQM I encourage you to read the three articles at the bottom of the CONTRIBUTING.md. They outline many of the expectations and reasons for preparing a PR in the way we do.

@schaubh
Copy link
Contributor

schaubh commented Nov 28, 2023

@patkenneally , are you ok with this branch then? I didn't see issues with his commits here. to make the requested change all these files had to be changed at once or the branch would not compile. Are you talking about him including the "removal of unneeded brackets" in these commits? He could have done that separately, I agree.

@patkenneally
Copy link
Contributor

Are you talking about him including the "removal of unneeded brackets" in these commits? He could have done that separately, I agree.

@schaubh Yes I'm referring to the inclusion of nonfunctional changes in the first commit. It's of course not a problem. I was hoping to help Lorenzzo learn these little things as we go. I don't advocate changing this PR.

@LorenzzoQM LorenzzoQM merged commit d2978e3 into develop Nov 28, 2023
2 checks passed
@LorenzzoQM LorenzzoQM deleted the refactor/508_storageUnit_longint_to_int64 branch November 28, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Refactor StorageUnit modules to use int64_t instead of long long int
3 participants