Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor StorageUnit modules to use int64_t instead of long long int #508

Closed
LorenzzoQM opened this issue Nov 23, 2023 · 0 comments · Fixed by #509
Closed

Refactor StorageUnit modules to use int64_t instead of long long int #508

LorenzzoQM opened this issue Nov 23, 2023 · 0 comments · Fixed by #509
Assignees
@LorenzzoQM
Labels
refactor Clean up with no new functionality

Comments

@LorenzzoQM
Copy link
Contributor

Describe your use case
Modules dataStorageUnitBase, simpleStorageUnit, and partitionedStorageUnit use long long int for storage capacity and storage level.

Describe alternatives solutions you've considered
The precise width type int64_t should be used instead to guarantee the same size of integers across platforms.
@LorenzzoQM LorenzzoQM self-assigned this Nov 23, 2023
@LorenzzoQM LorenzzoQM added the refactor Clean up with no new functionality label Nov 23, 2023
@LorenzzoQM LorenzzoQM linked a pull request Nov 24, 2023 that will close this issue
Refactor/508 change variable in StorageUnit from long int to int64_t #509
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LorenzzoQM LorenzzoQM

Labels
refactor Clean up with no new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor/508 change variable in StorageUnit from long int to int64_t AVSLab/basilisk
1 participant
@LorenzzoQM