Extras upscaler: option limit target resolution

[light-and-ray]

Description

By request: #15237

Useful for batches where can be big images, which give OOM error

Screenshots/videos:

Checklist:

• I have read contributing wiki page
• I have performed a self-review of my own code
• My code follows the style guidelines
• My code passes tests

[light-and-ray]

@drdancm is it correct? Or I should add something else?

[AUTOMATIC1111]

I'd rather not overcomplicate the UI with an option that 99.99% of users won't need. At least make it a setting.

[light-and-ray]

Done

[AUTOMATIC1111]

Well, that's not precisely what I had in mind. I wanted for the actual number to be set from settings, not for the checkbox for enabling/disabling, from the standpoint of making code less complex.

[light-and-ray]

I think it's much useful to have it in ui, because it's not only about avoiding OOM. Maybe someone wants to process folder to get images at maximum 2048p for instance. It's a useful option

[AUTOMATIC1111]

And he will go into settings and set it to 2048 there. If he needs to change it often, he can put it into the toprow.

[light-and-ray]

I want to have quick access to this, but don't want to see it in the quick settings.

Hmm, maybe I should extend extra options builtin extension to extras tab too?

[light-and-ray]

But I still think it's a good enough option of the script, and we should have it inside UI. Who thinks it too?

[light-and-ray]

@AUTOMATIC1111 You said: "99.99% of users won't need", so I think it's no matter either a slider is inside ui and checkbox in settings or a slider is inside settings

[AUTOMATIC1111]

Yes, my preference is the latter - a slider or, an input box, in settings.

[drdancm]

Looks good to me, however I think the explanation (when you hover) should make it clear that the max pixel resolution that this means the LONGEST SIDE. Probably what you have in mind, but making it super clear to people, would in my mind, make it impossible to miss-understand.

This is, in my opinion, an absolutely great improvement for anyone doing batch processing.
Thanks ! ! ! ! ! ! ! ! ! ! ! !

[drdancm]

Absolutely have this inside the UI, otherwise, people won't know about it. Users only look into SETTINGS, when something is missing. To new Users, the SETTINGS are pretty confusing. There are so many different settings, so many different names which are not intuitively obvious. Automatic 1111 is a fantastic and wonderful project, and although easier to use, and more powerful, than many similar programs, it is somewhat short on being easy to learn by someone who is not a programmer, and relies on a single click install in the first place.

[light-and-ray]

@AUTOMATIC1111 ready to merge @drdancm approved

[AUTOMATIC1111]

Well, I'm glad that drdancm approves, but that's a really small sample size. Is this feature even useful outside of batch jobs?

[light-and-ray]

Yes it is, but batch is the main. Why is it not enough?

[drdancm]

Batch jobs are quite important for any serious artists or photographer. In any case, what terrible harm does it cause you, or anyone who is not interested in using this feature, and cannot imagine why this would be extremely useful ?
After all, the batch feature is there, but without the target limit is is very inefficient.

[AUTOMATIC1111]

Here are my thoughts:

1. changing arguments of the function to **args is not something I want to merge in.
2. if this is only useful in batch mode, I'd rather have it as option in batch UI, without an option to disable it.

[light-and-ray]

if this is only useful in batch mode

Not only

changing arguments of the function to **args is not something I want to merge in.

Why? It looks better then too long arguments