Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Improved Extra Tab Features #15237

Open
1 task done
drdancm opened this issue Mar 13, 2024 · 6 comments
Open
1 task done

[Feature Request]: Improved Extra Tab Features #15237

drdancm opened this issue Mar 13, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@drdancm
Copy link

drdancm commented Mar 13, 2024

Is there an existing issue for this?

  • I have searched the existing issues and checked the recent builds/commits

What would your feature do ?

Automatic Scaling of Input Images
When working with a folder full of images where one side is greater than about 2000 pixels, processing may fail due to Video Card VRAM or some other limitations. The only current solution is to resize all of the images with an external graphics program. If the all of the images are the same size, this works well, if they are not, then manual scaling is often, though not always) the only solution.

In Automatic 1111, when working with img2img etc. there are two setting for the Scaling feature. One for setting x and y separately, and another for multiplying both x and y at once allowing both + and - values. In the Extras Tab, you are limited to + values (this is very bad!). In fact, in my experience, these settings do nothing at all. There is no scaling, thus the output image has the same size as the input image, regardless of any setting. Is there anyone who has experienced otherwise ?

Once again this requires extra manual work unless all of the images in a folder are the same size, and when using the Extras Tab (for Reactor for example), image sizes above your max value makes it unusable. Once again forcing you to use an external graphics program to downscale before you can run img2img etc.

I don't see why A1111 has not already built in an option to scale the input images automatically, so that the maximum size is limited to a user set value such as 1280, or 1600, or 2000 pixels (or specific values that work best for SDXL)).

Describe the idea you'd like

A1111 feature should in img2img, and especially in Extras Tab automatically set maximum pixel size for the longest side of an image. After all, this program is called "Automatic" right ?

In addition, would it be possible to also have a batch mode allowing the user to browse for both an input and and output folder. This would be far easier than having to change the semi-permanent setting whenever necessary, although the default of saving in the Source folder works great almost all the time.

Thanks !

ADDED LATER - In fact I stumbled on how to use the Scaling in the Extras TAB. Because the Upscaler type (4x-Ultrasharp etc.) is below the setting and appears to be part of a different section it was not, at least to me, obvious that it had to be filled out. Once again it does not work the way things are laid out in the img2img Tab. There you simply move the pointer to get scaling without apparently having to choose who does the scaling. So, now I can scale up, but still cannot scale down.

Proposed workflow

  1. Go to ....
  2. Press ....
  3. ...
    The automatic scaling could simply be a user setting, just in case someone does not want automatic scaling.

Additional information

No response

@drdancm drdancm added the enhancement New feature or request label Mar 13, 2024
@light-and-ray
Copy link
Contributor

Looks good, I will make it after auto will merge my other little upscaling script

@drdancm
Copy link
Author

drdancm commented Mar 15, 2024

Great, please take notice of my ADDED LATER note, in case it may help you with making the User Interface more obvious and therefore clearer..
Thanks!

@light-and-ray
Copy link
Contributor

@drdancm

@drdancm
Copy link
Author

drdancm commented Mar 18, 2024

Having your improvement inside the UI is vital.
I like your solution, but make sure when the explanation elicited by hovering over the parameter, clearly says, you are setting the max pixel resolution of the longest side!

Thanks ! ! ! ! !

@drdancm
Copy link
Author

drdancm commented Apr 26, 2024

Max size limit is now operational in A1111, when will we get this in FORGE ?

Thanks !

@light-and-ray
Copy link
Contributor

Forge is andoned, the authors ignores everybody's PR and doesn't merge webui dev branch. It's better to go back on a1111 @drdancm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants