Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add chara-searcher #348

Merged
merged 1 commit into from
Jul 22, 2024
Merged

add chara-searcher #348

merged 1 commit into from
Jul 22, 2024

Conversation

NON906
Copy link
Contributor

@NON906 NON906 commented Jul 20, 2024

Info

https://github.com/NON906/chara-searcher

"editing" is added to automatically remove the background.
Also, "query" is added to automatically tag images.
If they are not appropriate, please be corresponding.

Checklist:

  • I have read the Readme.md
  • The description is written in English.
  • The index.json and extension_template.json have not been modified.
  • The entry is placed in the extensions directory with the .json file extension.

@w-e-w
Copy link
Collaborator

w-e-w commented Jul 21, 2024

some issues


requirements.txt

gradio==3.41.2

https://github.com/NON906/chara-searcher/blob/1316b61637b353fa701078d49803450aaf90a832/requirements.txt#L3

I understand that since you provided standalone mode you put all the requirements inside one single requirements.txt

but this would highly likely cause issues especially gradio==3.41.2

when we eventually upgraded to Gradio 4 or if a user is on an old version of where you are that is not using gradio==3.41.2, your extentions insulation sequence with Force installation of gradio==3.41.2 which will break things

you would have to provide separate installation sequences / requirements for webui and standalone model

my PR should fix this issue

@w-e-w
Copy link
Collaborator

w-e-w commented Jul 21, 2024

I've encountered another issue during installation

but it only happens at the first couple of times when I try to install it and did not happen again after so I'm not sure how to replicate it
basically launch.run(f'"{launch.python}" -m mim install mmengine "mmcv>=2.0.0" mmdet') install mmcv
for some reason is sometimes it installs mmcv 2.2.0 and oter times 2.1.0
for me 2.2.0 seems to be incompatible with something (I'm not sure what) if this happens it will cause the extension to not work

@NON906
Copy link
Contributor Author

NON906 commented Jul 22, 2024

Sorry for the inconvenience.

The pull request has been reflected.

I also added version specifications for mmcv and mmdet in the following commits.
NON906/chara-searcher@10ce90e

@w-e-w w-e-w merged commit 0532bc9 into AUTOMATIC1111:extensions Jul 22, 2024
1 check passed
github-actions bot pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants