Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(S1068): delete field writes of violated field only #921

Merged
merged 4 commits into from
Oct 23, 2022
Merged

fix(S1068): delete field writes of violated field only #921

merged 4 commits into from
Oct 23, 2022

Conversation

algomaster99
Copy link
Member

I forgot to add a filter to delete field writes of only those field which are unused in #917 . The changes ensure that all field writes are not deleted.

@algomaster99
Copy link
Member Author

I ran the local build of the plugin on npefix and now it compiles after the repair.

@sonatype-lift
Copy link

sonatype-lift bot commented Oct 21, 2022

⚠️ 1 God Class was detected by Lift in this project. Visit the Lift web console for more details.

@algomaster99 algomaster99 changed the title fix(S1068): delete field writes of corresponding field only fix(S1068): delete field writes of violated field only Oct 21, 2022
khaes-kth
khaes-kth approved these changes Oct 23, 2022
View reviewed changes
Copy link
Collaborator

@khaes-kth khaes-kth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@khaes-kth khaes-kth merged commit 88b580a into master Oct 23, 2022
@khaes-kth khaes-kth deleted the fix-S1068 branch October 23, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaes-kth khaes-kth khaes-kth approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@algomaster99 @khaes-kth