Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(S1068): delete field writes as well #917

Merged
merged 3 commits into from
Oct 20, 2022
Merged

fix(S1068): delete field writes as well #917

merged 3 commits into from
Oct 20, 2022

Conversation

algomaster99
Copy link
Member

Fixes #913

@sonatype-lift
Copy link

sonatype-lift bot commented Oct 19, 2022

⚠️ 1 God Class was detected by Lift in this project. Visit the Lift web console for more details.

@algomaster99 algomaster99 mentioned this pull request Oct 19, 2022
Merged
@khaes-kth
Copy link
Collaborator

Does this mean we introduced compilation error by removing the field and not removing its write usage?

@algomaster99
Copy link
Member Author

@khaes-kth yes. Removal of field writes is not explicitly suggested by SonarSource, but we should do it to prevent compilation error.

@khaes-kth khaes-kth merged commit c67cbd8 into master Oct 20, 2022
@khaes-kth khaes-kth deleted the fix-S1068 branch October 20, 2022 09:26
@algomaster99 algomaster99 mentioned this pull request Oct 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaes-kth khaes-kth khaes-kth approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug in S1068
2 participants
@algomaster99 @khaes-kth