Fix alignment of execute region to 8byte boundary #8024

deepikabhavnani · 2018-09-06T21:04:50Z

Description

Resolves: #8004

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

0xc0170 · 2018-09-24T12:20:37Z

Why was #8186 created separately ? Not part of this update?

0xc0170 · 2018-09-24T12:22:45Z

One question, all device should have this alignment for the upcoming release so we should coordinate it all works and its updated (thus my above question about nxp one).

deepikabhavnani · 2018-09-24T14:51:34Z

@0xc0170 - Targets having more then 25 linker files were added into new PR so that respective teams can review. We have separate PR for NXP/Freescale #8186 and ST #8013.

I can merge all of them, but thought instead of 200+ file updates in single PR it is good to have target specific and again I didn't wanted to add PR per target also :-)

0xc0170 · 2018-09-24T15:01:29Z

OK, I was not certain as they were not linked and I discovered all of them going through PRs. Let's review all of them and make sure all targets the same release.

deepikabhavnani · 2018-09-24T15:05:13Z

All of them are linked to issue #8004 and not each other.

0xc0170 · 2018-10-01T12:08:30Z

Adding affected team (This is fixing the ARM legacy alignment issue #8004): Please review

@ARMmbed/team-silabs @ARMmbed/team-nuvoton @ARMmbed/team-toshiba @ARMmbed/team-maximintegrated @ARMmbed/team-renesas @ARMmbed/team-analogdevices @ARMmbed/team-onsemi @ARMmbed/team-realtek @ARMmbed/team-ublox

c1728p9

In addition to changing the '.sct' files to fix ARMC6 alignment it looks like the '.ld' and '.icf' files were also updated. Was this causing a problem or is this just for consistency?

deepikabhavnani · 2018-10-03T20:54:20Z

In addition to changing the '.sct' files to fix ARMC6 alignment it looks like the '.ld' and '.icf' files were also updated. Was this causing a problem or is this just for consistency?

just for consistency :-( . IAR files were actually mostly 8-byte aligned for all sections, except vectors

deepikabhavnani · 2018-10-08T20:42:27Z

Rebased to resolve conflicts

cmonr · 2018-10-09T01:33:55Z

/morph build

mbed-ci · 2018-10-09T04:05:23Z

Build : FAILURE

Build number : 3290
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8024/

cmonr · 2018-10-09T13:24:11Z

It's not the easiest thing to tell from the log, but there's a syntax error with the EFM32PG12_STK3402 target when compiling with GCC, on line 7.

--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files (GCC and IAR as well to have uniformity) should strictly align to 8-byte boundary

deepikabhavnani · 2018-10-09T15:15:12Z

It's not the easiest thing to tell from the log, but there's a syntax error with the EFM32PG12_STK3402 target when compiling with GCC, on line 7.

Missed semicolon in linker file.. Will amend the commit, hence listing here the change

-__vector_size = 0x110
+__vector_size = 0x110;

cmonr · 2018-10-09T15:27:10Z

/morph build

mbed-ci · 2018-10-09T16:25:17Z

Build : SUCCESS

Build number : 3297
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8024/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-09T18:02:19Z

Exporter Build : FAILURE

Build number : 2926
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8024/

0xc0170 · 2018-10-09T18:13:05Z

/morph export-build

mbed-ci · 2018-10-09T20:00:45Z

Exporter Build : SUCCESS

Build number : 2929
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8024/

mbed-ci · 2018-10-10T00:52:02Z

Test : SUCCESS

Build number : 3106
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8024/3106

cmonr added the needs: review label Sep 6, 2018

cmonr requested review from JanneKiiskila and 0xc0170 September 6, 2018 22:14

deepikabhavnani force-pushed the fix_align branch from fe9a724 to 33a4e0f Compare September 7, 2018 17:38

deepikabhavnani mentioned this pull request Sep 19, 2018

STM32: Fix alignment of execute region to 8byte boundary #8013

Merged

deepikabhavnani force-pushed the fix_align branch from 33a4e0f to 483e02f Compare September 19, 2018 15:20

0xc0170 approved these changes Sep 24, 2018

View reviewed changes

0xc0170 requested a review from a team September 24, 2018 12:22

deepikabhavnani mentioned this pull request Sep 24, 2018

Freescale/NXP: Fix alignment of execute region to 8byte boundary #8186

Merged

M-ichae-l approved these changes Oct 2, 2018

View reviewed changes

TomoYamanaka approved these changes Oct 2, 2018

View reviewed changes

c1728p9 approved these changes Oct 3, 2018

View reviewed changes

cyliangtw approved these changes Oct 5, 2018

View reviewed changes

deepikabhavnani force-pushed the fix_align branch from 483e02f to 7fca9f5 Compare October 8, 2018 20:42

cmonr added needs: CI and removed needs: review labels Oct 9, 2018

cmonr added needs: work and removed needs: CI labels Oct 9, 2018

Nuvoton: Fix alignment of execute region to 8-byte boundary

e1ecce8

--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files (GCC and IAR as well to have uniformity) should strictly align to 8-byte boundary

Deepika added 12 commits October 9, 2018 10:15

Nordic: Fix alignment of execute region to 8-byte boundary

61404e6

--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files (GCC and IAR as well to have uniformity) should strictly align to 8-byte boundary

Toshiba: Fix alignment of execute region to 8-byte boundary

8c17ff6

--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files (GCC and IAR as well to have uniformity) should strictly align to 8-byte boundary

Atmel: Fix alignment of execute region to 8-byte boundary

5a25fd9

--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files (GCC and IAR as well to have uniformity) should strictly align to 8-byte boundary

Maxim: Fix alignment of execute region to 8-byte boundary

a6997ab

--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files (GCC and IAR as well to have uniformity) should strictly align to 8-byte boundary

ARM: Fix alignment of execute region to 8-byte boundary

2a8ae84

--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files (GCC and IAR as well to have uniformity) should strictly align to 8-byte boundary

Renesas: Fix alignment of execute region to 8-byte boundary

d120222

--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files (GCC and IAR as well to have uniformity) should strictly align to 8-byte boundary

Analog Devices: Fix alignment of execute region to 8-byte boundary

26dc7bd

--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files (GCC and IAR as well to have uniformity) should strictly align to 8-byte boundary

Onsemi: Fix alignment of execute region to 8-byte boundary

2d95fcb

--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files (GCC and IAR as well to have uniformity) should strictly align to 8-byte boundary

Wiznet: Fix alignment of execute region to 8-byte boundary

05fe53a

--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files (GCC and IAR as well to have uniformity) should strictly align to 8-byte boundary

Realtek: Fix alignment of execute region to 8-byte boundary

1a6048f

--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files (GCC and IAR as well to have uniformity) should strictly align to 8-byte boundary

Ublox: Fix alignment of execute region to 8-byte boundary

4566241

--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files (GCC and IAR as well to have uniformity) should strictly align to 8-byte boundary

SiLabs: Fix alignment of execute region to 8-byte boundary

08051f5

--legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files (GCC and IAR as well to have uniformity) should strictly align to 8-byte boundary

deepikabhavnani force-pushed the fix_align branch from 7fca9f5 to 08051f5 Compare October 9, 2018 15:15

cmonr added needs: CI and removed needs: work labels Oct 9, 2018

0xc0170 added the release-version: 5.10.2 label Oct 9, 2018

cmonr added ready for merge and removed needs: CI labels Oct 10, 2018

cmonr merged commit ab064df into ARMmbed:master Oct 10, 2018

cmonr removed the ready for merge label Oct 10, 2018

deepikabhavnani deleted the fix_align branch October 10, 2018 14:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix alignment of execute region to 8byte boundary #8024

Fix alignment of execute region to 8byte boundary #8024

deepikabhavnani commented Sep 6, 2018

0xc0170 commented Sep 24, 2018

0xc0170 commented Sep 24, 2018

deepikabhavnani commented Sep 24, 2018

0xc0170 commented Sep 24, 2018

deepikabhavnani commented Sep 24, 2018

0xc0170 commented Oct 1, 2018

c1728p9 left a comment

deepikabhavnani commented Oct 3, 2018 •

edited

Loading

deepikabhavnani commented Oct 8, 2018

cmonr commented Oct 9, 2018

mbed-ci commented Oct 9, 2018

cmonr commented Oct 9, 2018

deepikabhavnani commented Oct 9, 2018

cmonr commented Oct 9, 2018

mbed-ci commented Oct 9, 2018

mbed-ci commented Oct 9, 2018

0xc0170 commented Oct 9, 2018

mbed-ci commented Oct 9, 2018

mbed-ci commented Oct 10, 2018

Fix alignment of execute region to 8byte boundary #8024

Fix alignment of execute region to 8byte boundary #8024

Conversation

deepikabhavnani commented Sep 6, 2018

Description

Pull request type

0xc0170 commented Sep 24, 2018

0xc0170 commented Sep 24, 2018

deepikabhavnani commented Sep 24, 2018

0xc0170 commented Sep 24, 2018

deepikabhavnani commented Sep 24, 2018

0xc0170 commented Oct 1, 2018

c1728p9 left a comment

Choose a reason for hiding this comment

deepikabhavnani commented Oct 3, 2018 • edited Loading

deepikabhavnani commented Oct 8, 2018

cmonr commented Oct 9, 2018

mbed-ci commented Oct 9, 2018

Build : FAILURE

cmonr commented Oct 9, 2018

deepikabhavnani commented Oct 9, 2018

cmonr commented Oct 9, 2018

mbed-ci commented Oct 9, 2018

Build : SUCCESS

Triggering tests

mbed-ci commented Oct 9, 2018

Exporter Build : FAILURE

0xc0170 commented Oct 9, 2018

mbed-ci commented Oct 9, 2018

Exporter Build : SUCCESS

mbed-ci commented Oct 10, 2018

Test : SUCCESS

deepikabhavnani commented Oct 3, 2018 •

edited

Loading