Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARMC6: legacy align error #8004

Closed
0xc0170 opened this issue Sep 5, 2018 · 4 comments
Closed

ARMC6: legacy align error #8004

0xc0170 opened this issue Sep 5, 2018 · 4 comments

Comments

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 5, 2018

Description

This PR removed legacy align : #7792 . It produces warning. This removed warning but causing now failures to use scatter files we have in the code base as they rely on the alignment that is now legacy. This leads to linker errors (4 vs 8 byte alignment). I could not find documentation why this alignment was deprecated but causing "breaking change" in this case as we would need to update all scatter files to use a new alignment.

@deepikabhavnani @JanneKiiskila

Issue request type

[ ] Question
[ ] Enhancement
[X] Bug

@deepikabhavnani
Copy link

deepikabhavnani commented Sep 5, 2018

As per the http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0803g/pge1362075504330.html, --legacyalign, --no_legacyalign are deprecated, hence were removed from mbed-os.

We have two options to resolve the issue:

  1. Fix the sections in scatter file to fix the alignment issue
  2. Enabling deprecated option --legacyalign

I would prefer option 1.
[Mirrored to Jira]

@JanneKiiskila
Copy link
Contributor

JanneKiiskila commented Sep 5, 2018

PR to fix this - #8012 - get things working ASAP, then do fix 2 once you have a test that actually verifies the targets. The scatter file changes are sort of trivial, BUT - there are so many of them that it's not a quick and easy fix to get them all sorted out.

[Mirrored to Jira]

@cmonr
Copy link
Contributor

cmonr commented Sep 6, 2018

Going to keep this open for now even though #8012 has been merged.
If we want to remove the legacyalign flag, we should fix the files and figure out why the deperecated flag led to behavior changes.
[Mirrored to Jira]

@adbridge
Copy link
Contributor

adbridge commented Oct 4, 2018

Internal Jira reference: https://jira.arm.com/browse/IOTCORE-415

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants