Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release candidate for mbed-os-5.4.2 #4025

Merged
merged 59 commits into from
Mar 29, 2017
Merged

Release candidate for mbed-os-5.4.2 #4025

merged 59 commits into from
Mar 29, 2017

Conversation

adbridge
Copy link
Contributor

No description provided.

adustm and others added 30 commits March 24, 2017 20:37
…---+--------+ | test case | passed | failed | result | +---------------------------+--------+--------+--------+ | mbedtls_aes_self_test | 1 | 0 | OK | | mbedtls_entropy_self_test | 1 | 0 | OK | | mbedtls_sha256_self_test | 1 | 0 | OK | | mbedtls_sha512_self_test | 1 | 0 | OK | +---------------------------+--------+--------+--------+
…dtls_device.h remove function alternate defines (not used as we replace the full module)
…(unrequired removed + other moved to aes_alt.h) hcryp_aes moved to mbedtls_aes_context to allow multi instances remove ctx->nr, ctx->buf doxygen comments are removed (kept in .h file) function _ALT are removed (full module _ALT) handle error returned by HAL_CRYPxx functions aes is symetric, remove the dupplicated set_key_enc and set_key_dec buffer, and factorize the call to set_key function
Calling Thread::start multiple times leads to undefined behavior since
the Thread class was not designed to handle being restarted.  Return an
error code if Thread::start is called a second time to prevent this
behavior.
If a thread hasn't been started return Inactive as the status when
Thread::get_state() is called.
Make the copy constructor and assignment operator private to prevent
them from being used.
Resolves the github issue #3790: Blinky fails to build (on Mac) after
addition of linker script preprocessing feature. Paraphrasing, this
issue is that Homebrew on mac does not install `arm-none-eabi-gcc` in
the same location as `arm-none-eabi-cpp`, the C Pre-Processor. The tools
prior to this commit, and after turning on the pre-processing of the
linker-script will fail on any Mac homebrew installed toolchains.

This commit resolves the above issue by allowing the toolchain's path to
the executable to remain empty after a call to `check_executable`. When
this path is empty, the tools will search the PATH environment variable
for the executable.
Currently, there is the issue in register setting into serial_format().
The issue is that parameter for baudrate setting is initialed zero in this function.
In baudrate  is less 9600bps, the issue occurs. In baudrate  is over 9600, not occurs. When call serial_baud() before serial_format(), baudrate override and set with an incorrect value.

Therefore, I fixed register setting not to set the parameter of baudrate setting in serial_format().
Add an 'all' parameter to get_flash_algorthim_binary. When set
an enumerator of all flash algorithms is returned. rather than just
the first flash algorithm.
Use python's LooseVersion to get the correct version.
Rebuild the json files used by arm-pack-manager now that a bug in
version selection has been fixed.
Load aliases.json from mbed-os rather than from a temporary
directory.
In targets.json, add lf_clock_rc_calib_timer_interval and
lf_clock_rc_calib_mode_config setting which are essential when using BLE
In mbed_overrides.c, create valuables instead of doing printf, those
valuables are intended to be used for debugging in runtime.
Change NUC472 analogin_api.c accordingly
@adbridge
Copy link
Contributor Author

/morph test-nightly

@adbridge
Copy link
Contributor Author

/morph mbed2-release

@bridadan
Copy link
Contributor

/morph export-build

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 144

All exports and builds passed!

@mbed-bot
Copy link

Result: UNSTABLE

Your command has finished executing! Here's what you wrote!

/morph mbed2-release

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1741

All builds and test passed!

@teetak01
Copy link
Contributor

@adbridge is this PR missing from the RC? #3939

@teetak01
Copy link
Contributor

@0xc0170 @bridadan please check if the #3939 could be returned. Its a release blocker for us.

FYI: @JanneKiiskila @yogpan01

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 27, 2017

@0xc0170 @bridadan please check if the #3939 could be returned. Its a release blocker for us.

Anna is away for 2 days. From what I understood on Friday, this PR introduced some conflicts that were not easy to resolve. If you can help you and apply this patch to the 3939 (releaase candidate), that would be helpful

* commit 'c8a16cc274fbbb074909690a78a9d2aaf5411d5a':
  Squashed 'features/FEATURE_COMMON_PAL/mbed-trace/' changes from 31e338c23..af5f59cd2
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 28, 2017

/morph test-nightly

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 28, 2017

/morph mbed2-release

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 28, 2017

/morph export-build

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1754

Example Prep failed!

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 145

Exporter Build failed!

@mbed-bot
Copy link

Result: UNSTABLE

Your command has finished executing! Here's what you wrote!

/morph mbed2-release

@bridadan
Copy link
Contributor

For once the mbed 2 tests were the most stable 😛

Ok, apollogies for the failure everybody. It looks likes the 2 morph jobs basically tripped up over each other (they were both oddly using the same directories when they shouldn't have been). I will kick off replacement tests. Please do not start any more jobs, thanks.

/morph test-nightly

@bridadan
Copy link
Contributor

/morph export-build

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 146

All exports and builds passed!

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1762

All builds and test passed!

@bridadan
Copy link
Contributor

7 checks all green! Thanks for your patience! @0xc0170 @adbridge @sg-

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 29, 2017

Thanks @bridadan

@0xc0170 0xc0170 merged commit 50b3418 into mbed-os-5.4 Mar 29, 2017
@adbridge
Copy link
Contributor Author

adbridge commented Mar 30, 2017

Should be noted that we actually have more regressions for the mbed 2 testing:

test.KL25Z.GCC_ARM.RTOS_1.Basic thread 	
test.KL25Z.GCC_ARM.RTOS_2.Mutex resource lock
test.KL25Z.GCC_ARM.RTOS_3.Semaphore resource lock
test.KL25Z.GCC_ARM.RTOS_4.Signals messaging 	
test.KL25Z.GCC_ARM.RTOS_5.Queue messaging 	
test.KL25Z.GCC_ARM.RTOS_6.Mail messaging 	
test.KL25Z.GCC_ARM.RTOS_8.ISR (Queue) 	
test.KL25Z.IAR.RTOS_2.Mutex resource lock 	
test.KL25Z.IAR.RTOS_3.Semaphore resource lock

test.NUCLEO_L053R8.IAR.MBED_24.Timeout Int us

test.LPC1114.ARM.MBED_37.Serial NC RX 	
test.LPC1114.ARM.MBED_38.Serial NC TX 	
test.LPC1114.GCC_ARM.MBED_37.Serial NC RX 
test.LPC1114.GCC_ARM.MBED_38.Serial NC TX 	
test.LPC1114.IAR.MBED_37.Serial NC RX 	
test.LPC1114.IAR.MBED_38.Serial NC TX 	
test.LPC1114.uARM.MBED_37.Serial NC RX 
test.LPC1114.uARM.MBED_38.Serial NC TX 	

test.LPC1768.ARM.MBED_37.Serial NC RX 
test.LPC1768.ARM.MBED_38.Serial NC TX 	
test.LPC1768.ARM.MBED_A18.Interrupt vector relocation 
test.LPC1768.ARM.MBED_A2.Semihost file system 	
test.LPC1768.GCC_ARM.MBED_37.Serial NC RX 	
test.LPC1768.GCC_ARM.MBED_38.Serial NC TX 	
test.LPC1768.GCC_ARM.MBED_A18.Interrupt vector relocation 
test.LPC1768.GCC_ARM.MBED_A2.Semihost file system 	
test.LPC1768.IAR.MBED_16.RTC 	
test.LPC1768.IAR.MBED_37.Serial NC RX 
test.LPC1768.IAR.MBED_38.Serial NC TX 	
test.LPC1768.IAR.MBED_A18.Interrupt vector relocation 	
test.LPC1768.IAR.MBED_A2.Semihost file system 	
test.LPC1768.uARM.MBED_37.Serial NC RX 	
test.LPC1768.uARM.MBED_38.Serial NC TX 	
test.LPC1768.uARM.MBED_A18.Interrupt vector relocation 
test.LPC1768.uARM.MBED_A2.Semihost file system 

test.SSCI824.GCC_ARM.MBED_37.Serial NC RX 	
test.SSCI824.GCC_ARM.MBED_38.Serial NC TX 	
test.SSCI824.uARM.MBED_24.Timeout Int us 	
test.SSCI824.uARM.MBED_37.Serial NC RX 	
test.SSCI824.uARM.MBED_38.Serial NC TX 

We do periodically get some serial and timeout failures, but I am more concerned about the Interrupt vector relocation, semihost file system and RTOS failures which appear to be new...These should have been looked at and commented on before the release candidate was merged...

@adbridge
Copy link
Contributor Author

adbridge commented Mar 30, 2017

Checking previous runs:
LPC1768 was last run 24/2 candidate. The serial tests failed there too, as did the Interrupt vector relocation, so those are not regressions. However semihost file system passed then, so that is a regression.
NUCLEO_L053R8.IAR.MBED_24.Timeout Int us is a known failure, so not a regression.
LPC1114 serial tests are known failures, so not a regression.
KL25Z last run 30/12 , had the same failures, so not a regression.
SSCI824 showing serial and timeout failures , which are known so again not a regression.

SUMMARY
Just the one regression:

test.LPC1768.ARM.MBED_A2.Semihost file system 	
test.LPC1768.GCC_ARM.MBED_A2.Semihost file system 	
test.LPC1768.IAR.MBED_A2.Semihost file system 	
test.LPC1768.uARM.MBED_A2.Semihost file system 

@bridadan
Copy link
Contributor

Thanks for checking the results @adbridge. Maybe @geky and/or @simonqhughes can take a look at the semihost failure?

@adbridge
Copy link
Contributor Author

We will ship with this as a known issue for v139 but yes it would be good for @geky or @simonqhughes to take a look at the failure to see it is reproducible or a one off.

@geky
Copy link
Contributor

geky commented Mar 30, 2017

Currently looking into it. Related issue: #3983

@geky
Copy link
Contributor

geky commented Mar 30, 2017

There is a fix up #3773, however it's relatively involved and probably restricted to 5.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.