Filesystem: Restructure the filesystem api to be consistent with mbed OS #3773
Conversation
geky
changed the title
geky
force-pushed
the
fs-filesystem-simple-3
branch
2 times, most recently
from
efe9d87
to
8b63749
Compare
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
@geky What are the failures? I had a look it differs between those 2 builds and do not seem to be related. I'll restart. Is this intended to be merged prior #3762 (thus would become part of it) ? @simonqhughes please comment. Looking at the scope of this, it should get in if it's ready, otherwise will be postponed for the next minor version. /morph test-nightly |
|
@0xc0170 The first failure was an issue with infrastructure and can be ignored. The second failure however is a real failure. It looks like some of the tests being built are too big for certain platforms? |
|
I'm going to have to check the CI again once it completes, I was having a hard time understanding the errors. If this is under consideration it may be impossible to get in until #3762 is merged. I'm going to run CI again for more info since the servers don't seem too stressed out. |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
From the logs, what I saw there - few overflow sections (tests are too big) and one undefined file handle (I think it was LPC1768), please have a look at those failures |
geky
force-pushed
the
fs-filesystem-simple-3
branch
from
ba341d9
to
929958b
Compare
Intention is to make filesystem api and network stack api consistent as current designs diverge greatly. Attempted to change as little as possible outside of api structure.
- Changed to use dirent structure type - Fixed memory leak in closedir
geky
force-pushed
the
fs-filesystem-simple-3
branch
from
929958b
to
38a29d3
Compare
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
geky
force-pushed
the
fs-filesystem-simple-3
branch
from
38a29d3
to
129bae4
Compare
|
/morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
@sg- LGTM! |
This patch restructures the filesystem components to be consistent with other mbed style apis.
feature-storage...geky:fs-filesystem-simple-3#diff-c9a9297200b57039e6ae5ca4ebd28d37
Note: No changes to the posix api, filesystem tests were passing without changes
Note: Not sure this pr will make it in, this has less priority than the other components of the storage branch, so feel free to dismiss.
cc @simonqhughes