Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32F1: Correct timer master value reading #3076

Merged
merged 1 commit into from
Oct 26, 2016
Merged

STM32F1: Correct timer master value reading #3076

merged 1 commit into from
Oct 26, 2016

Conversation

bcostm
Copy link
Contributor

@bcostm bcostm commented Oct 19, 2016

Description

The reading of the Timer master value was not done correctly. Apply same method as done in STM32F0. This should fix the issue #2910

Status

READY

Migrations

No

Related PRs

None

@bridadan
Copy link
Contributor

/morph test

@bridadan
Copy link
Contributor

@mbed-bot: TEST

HOST_OSES=ALL
BUILD_TOOLCHAINS=ALL
TARGETS=ALL

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 0

All builds and test passed!

@mbed-bot
Copy link

[Build 1055]
FAILURE: Something went wrong when building and testing.

bridadan
bridadan approved these changes Oct 20, 2016
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Testato
Copy link

Testato commented Oct 21, 2016

seems that here is there a better solution ?
https://developer.mbed.org/questions/69346/Wait-function-shows-incorrect-timing-on-/#answer11316

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 24, 2016

seems that here is there a better solution ?
https://developer.mbed.org/questions/69346/Wait-function-shows-incorrect-timing-on-/#answer11316

@bcostm What do you think?

@bcostm
Copy link
Contributor Author

bcostm commented Oct 25, 2016 •
edited
Loading

Well, even if the propose change looks ok I prefer to merge my PR as it is now because it is the same as done for the other platforms. But we are thinking to factorise the ticker files (hal_tick and us_ticker) in order to have one single file. So we'll consider this change when we'll do this. Is that ok for you ?

@0xc0170 0xc0170 merged commit 7499177 into ARMmbed:master Oct 26, 2016
@Testato
Copy link

Testato commented Nov 21, 2016

is this correction applied also on mbed-dev ?
Because i use Platformio and the problem is present yet

@bcostm bcostm deleted the fix_issue-2910_nucleo-f103rb branch November 21, 2016 14:59
@Testato
Copy link

Testato commented Nov 22, 2016 •
edited
Loading

ok, is the Platformio that is on old 127 mbed version
I tested mbed 129 and it work

@Testato Testato mentioned this pull request Nov 22, 2016
Closed
aisair pushed a commit to aisair/mbed that referenced this pull request Apr 30, 2024
Release 128 of the mbed library
2a871fe 
Ports for Upcoming Targets


Fixes and Changes

2966: Add kw24 support ARMmbed/mbed-os#2966
3068: MultiTech mDot - clean up PeripheralPins.c and add new pin names ARMmbed/mbed-os#3068
3089: Kinetis HAL: Remove clock initialization code from serial and ticker  ARMmbed/mbed-os#3089
2943: [NRF5] NVIC_SetVector functionality ARMmbed/mbed-os#2943
2938: InterruptIn changes in NCS36510 HAL. ARMmbed/mbed-os#2938
3108: Fix sleep function for NRF52. ARMmbed/mbed-os#3108
3076: STM32F1: Correct timer master value reading ARMmbed/mbed-os#3076
3085: Add LOWPOWERTIMER capability for NUCLEO_F303ZE ARMmbed/mbed-os#3085
3046: [BEETLE] Update BLE stack on Beetle board ARMmbed/mbed-os#3046
3122: [Silicon Labs] Update of Silicon Labs HAL ARMmbed/mbed-os#3122
3022: OnSemi RAM usage fix ARMmbed/mbed-os#3022
3121: STM32F3: Correct UART4 and UART5 defines when using DEVICE_SERIAL_ASYNCH ARMmbed/mbed-os#3121
3142: Targets- NUMAKER_PFM_NUC47216 remove mbed 2 ARMmbed/mbed-os#3142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bridadan bridadan bridadan approved these changes

Assignees
No one assigned
Labels
release-version: 5.2.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bcostm @bridadan @mbed-bot @Testato @0xc0170