OnSemi RAM usage fix #3022
OnSemi RAM usage fix #3022
Conversation
|
@kjbracey-arm @c1728p9 |
| DCD fIrqUart2Handler | ||
| DCD fIrqUviHandler | ||
| DCD fIrqDmaHandler | ||
| DCD fIrqDbgPwrUpHandler |
There was a problem hiding this comment.
@hasnainvirk Minor gripe: looks like some indentation got messed up here? Mind taking a look?
There was a problem hiding this comment.
@bridadan This is strange, if I view the file or see it on my local editor, everything is fine. I think git diff is messing it up here. I don't think I can do much about that
|
Comment clarity - this isn't affecting the main stack at all (assuming by main stack we mean the stack of main()). It's removing a dedicated 4K region used only for the initial "boot" stack, and using the top of the heap area for initial boot stack instead, as many other platforms do. And also it removes an unused 1K RAM region. Total saving 5K. |
Previous code base had been wasting almost 4K of precious RAM. * Main stack allocation reduced from 4K to 1K * Un-necessary breakdown of RAM regions is removed. This gives us back 2K of RAM.
hasnainvirk
force-pushed
the
ncs36510_fixes
branch
from
ac525a3
to
1b6f3cd
Compare
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 0 All builds and test passed! |
Ports for Upcoming Targets Fixes and Changes 2966: Add kw24 support ARMmbed/mbed-os#2966 3068: MultiTech mDot - clean up PeripheralPins.c and add new pin names ARMmbed/mbed-os#3068 3089: Kinetis HAL: Remove clock initialization code from serial and ticker ARMmbed/mbed-os#3089 2943: [NRF5] NVIC_SetVector functionality ARMmbed/mbed-os#2943 2938: InterruptIn changes in NCS36510 HAL. ARMmbed/mbed-os#2938 3108: Fix sleep function for NRF52. ARMmbed/mbed-os#3108 3076: STM32F1: Correct timer master value reading ARMmbed/mbed-os#3076 3085: Add LOWPOWERTIMER capability for NUCLEO_F303ZE ARMmbed/mbed-os#3085 3046: [BEETLE] Update BLE stack on Beetle board ARMmbed/mbed-os#3046 3122: [Silicon Labs] Update of Silicon Labs HAL ARMmbed/mbed-os#3122 3022: OnSemi RAM usage fix ARMmbed/mbed-os#3022 3121: STM32F3: Correct UART4 and UART5 defines when using DEVICE_SERIAL_ASYNCH ARMmbed/mbed-os#3121 3142: Targets- NUMAKER_PFM_NUC47216 remove mbed 2 ARMmbed/mbed-os#3142
Notes:
Description
Recovers 4K of precious RAM. Valid only for ARMCC. Similar fixes should be done to GCC and IAR too.
Status
READY/IN DEVELOPMENT/HOLD
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
YES | NO
Related PRs
List related PRs against other branches:
Todos
Deploy notes
Notes regarding the deployment of this PR. These should note any
required changes in the build environment, tools, compilers, etc.
Steps to test or reproduce
Outline the steps to test or reproduce the PR here.
Previous code base had been wasting almost 4K of precious RAM.