TARGET_NRF5: Changed 'serial_baud' implementation to support special baud rates. #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rates like 56000 or 31250.
|
/morph test |
| // directly) to make it possible to set special baud rates like 56000 | ||
| // or 31250. | ||
|
|
||
| uint32_t const acceptedSpeeds[][2] = { |
There was a problem hiding this comment.
why is this not static? compiler might be smart enough but can't confirm it.
I assume this is a tradeoff, to save RAM space, thus this is intended to be init in the runtime (=on stack), is it? just checking :)
There was a problem hiding this comment.
You're right. It should be static. It is a const array, so it will (should) be placed in flash. Hence, I thought static would not make any difference. Obviously, it won't hurt.
Apparently, with static added the resulting hex is 16 bytes shorter. I'm not sure why, though.
I added a proper commit.
|
looks ok. |
|
Thanks @nvlsianpu for review |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 866 All builds and test passed! |
|
This looks good to me |
|
@mbed-bot: TEST HOST_OSES=ALL |
|
[Build 929] |
artokin
added a commit
to artokin/mbed-os
that referenced
this pull request
Dec 2, 2021
…25a4af..154db5425e 154db5425e Merge branch 'release_internal' into release_external dca258c3f0 Updated unit test 89df990e6d Set EAPOL relay state function to LLC as a callback 47d8f42bf5 Removed extra call to supplicant delete callback 00ebfd905f Added new configuration options for Border router 421f6a8191 Move RPL code to the 6lr state machine e1e43b8ac2 Corrected pae controller BR EUI-64 flagging aaefdaebab Refactored pae controller (ARMmbed#2707) b82e0ee19a Update copyright text in CMakeLists.txt files (ARMmbed#2706) 5791a22d37 Renamed bootstrap files and separated pae controller callback functions (ARMmbed#2703) 4e3ec07caf MAC beacon payload max MTU allocation limited to for support MTU size 127. a997ab6653 Iotthd 4698 (ARMmbed#2702) e64b057bff Adjusted security protocols timeouts (ARMmbed#2701) cb3db6419f Return invalid values from old API if new configuration is used 6872401f8d RPL address registration update 90a434d318 RPL DAO lifetime update e39f6432eb Forward RPL configuration unmodified 58da4d6c93 Sync Cmake updates from Mbed OS (ARMmbed#2697) 4c229b46c9 Adjust Wi-SUN host/router config - HAVE_RPL (ARMmbed#2696) 40bd2320ba Update release v15.0.0 details to CHANGELOG (ARMmbed#2694) git-subtree-dir: connectivity/nanostack/sal-stack-nanostack git-subtree-split: 154db5425eb9f0df82ee081cb05e7d80cda11415
artokin
added a commit
to artokin/mbed-os
that referenced
this pull request
Dec 8, 2021
…25a4af..154db5425e 154db5425e Merge branch 'release_internal' into release_external dca258c3f0 Updated unit test 89df990e6d Set EAPOL relay state function to LLC as a callback 47d8f42bf5 Removed extra call to supplicant delete callback 00ebfd905f Added new configuration options for Border router 421f6a8191 Move RPL code to the 6lr state machine e1e43b8ac2 Corrected pae controller BR EUI-64 flagging aaefdaebab Refactored pae controller (ARMmbed#2707) b82e0ee19a Update copyright text in CMakeLists.txt files (ARMmbed#2706) 5791a22d37 Renamed bootstrap files and separated pae controller callback functions (ARMmbed#2703) 4e3ec07caf MAC beacon payload max MTU allocation limited to for support MTU size 127. a997ab6653 Iotthd 4698 (ARMmbed#2702) e64b057bff Adjusted security protocols timeouts (ARMmbed#2701) cb3db6419f Return invalid values from old API if new configuration is used 6872401f8d RPL address registration update 90a434d318 RPL DAO lifetime update e39f6432eb Forward RPL configuration unmodified 58da4d6c93 Sync Cmake updates from Mbed OS (ARMmbed#2697) 4c229b46c9 Adjust Wi-SUN host/router config - HAVE_RPL (ARMmbed#2696) 40bd2320ba Update release v15.0.0 details to CHANGELOG (ARMmbed#2694) git-subtree-dir: connectivity/nanostack/sal-stack-nanostack git-subtree-split: 154db5425eb9f0df82ee081cb05e7d80cda11415
aisair
pushed a commit
to aisair/mbed
that referenced
this pull request
Apr 30, 2024
Ports for Upcoming Targets 2669: Added u-blox C029 target ARMmbed/mbed-os#2669 2707: [EFM32] Add IAR support for remaining Silicon Labs targets ARMmbed/mbed-os#2707 2819: MultiTech xDot platform support - 09.26.2016 ARMmbed/mbed-os#2819 2827: include MultiTech xDot in mbed 5 releases ARMmbed/mbed-os#2827 Fixes and Changes 2522: Add CThunk for CM7 ARMmbed/mbed-os#2522 2518: Enable uvisor on Beetle ARMmbed/mbed-os#2518 2571: STM32F7 - Add asynchronous serial ARMmbed/mbed-os#2571 2616: STM32F3xx - Add Serial Flow Control pins + enable it ARMmbed/mbed-os#2616 2619: NUCLEO_L152RE - Add Serial Flow Control ARMmbed/mbed-os#2619 2620: NUCLEO_F429ZI - Add SERIAL_FC macro ARMmbed/mbed-os#2620 2666: [EFM32] Microsecond ticker optimization ARMmbed/mbed-os#2666 2681: STM32F0xx - Add support of ADC internal channels ARMmbed/mbed-os#2681 2687: [NRF5] Add fs_data symbol in data secton for gcc ARMmbed/mbed-os#2687 2696: Add device_has to all nrf51 devices ARMmbed/mbed-os#2696 2703: TARGET_NRF5: Changed 'serial_baud' implementation to support special baud rates. ARMmbed/mbed-os#2703 2704: DISCO_L476VG: add SPI nicknames ARMmbed/mbed-os#2704 2723: KSDK serial_api.c: Fix assertion error for ParityEven ARMmbed/mbed-os#2723 2463: [STM32L0] Add asynchronous serial ARMmbed/mbed-os#2463 2572: Fix STM32F407VG target name and LPC11U6X linker errors ARMmbed/mbed-os#2572 2698: DELTA_DFBM_NQ620 target ARMmbed/mbed-os#2698 2542: Dev spi asynch stm32f4 ARMmbed/mbed-os#2542 2650: STM32F3 - Add low power timer ARMmbed/mbed-os#2650 2415: [STM32F0] Add asynchronous serial ARMmbed/mbed-os#2415 2585: Added support for ADC only pins in LPC43xx ARMmbed/mbed-os#2585 2622: [STM32F4] Add asynchronous I2C ARMmbed/mbed-os#2622 2719: Updated ARM linker scripts for Kinetis platforms that use SDK 2.0 ARMmbed/mbed-os#2719 2728: Added ethernet and enabled IPV4 feature for the EVK-ODIN-W2/C029 target ARMmbed/mbed-os#2728 2747: [LPC11U68] Fix pin interrupt select offset ARMmbed/mbed-os#2747 2751: STM32L0xx - Add Serial Flow Control ARMmbed/mbed-os#2751 2753: [NUCLEO_F767ZI] Add CAN capability ARMmbed/mbed-os#2753 2759: STM32F0 - Add low power timer ARMmbed/mbed-os#2759 2763: STM32L1 - Add low power timer ARMmbed/mbed-os#2763 2764: STM32L4 - Add low power timer ARMmbed/mbed-os#2764 2771: STM32L4 - Update deepsleep implementation ARMmbed/mbed-os#2771 2775: Update KSDK SDHC driver for K64F & K66F ARMmbed/mbed-os#2775 2792: [NUCLEO_F303ZE] MBED-OS5 capability ARMmbed/mbed-os#2792 2762: STM32L0 - Add low power timer ARMmbed/mbed-os#2762 2761: STM32F7 - Add low power timer ARMmbed/mbed-os#2761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were needed to make daplink-validation test pass (it uses baud rate 56000, which was not properly handled by previous implementation).