-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM32F3 - Add low power timer #2650
Conversation
Can we do it just for the deepsleep tests (with comment that us_ticker may be switched off), just so we don't test lp_ticker using lp_ticker for all cases. |
That is the idea. I tried this option but I still have some trouble with the automatic test because there is no check of the end of serial transmit before entering in deepsleep mode.
So the test pass but the dummy characters make it fail. However, I opened a PR for that #2651. |
I'd wait for #2651 to be merged first. |
@mbed-bot: TEST HOST_OSES=ALL |
@svastm needs a rebase |
[Build 900] |
rebased |
@mbed-bot: TEST HOST_OSES=ALL |
[Build 908] |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 834 All builds and test passed! |
I rebase because i forgot to include |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
Outputmbed Build Number: 864 All builds and test passed! |
Rebase again. I remove the last commit which avoid multiple init of HAL_tick. This implementation could cause some errors if you need to call twice HAL_Osc_Init to init the clock. Also, for now the us_timer is reset if you enter in deepsleep. |
@svastm could you rebase and resolve conflicts? |
rebased |
Enable the low power timer for the following targets: - NUCLEO_F302R8 - NUCLEO_F303K8 - NUCLEO_F303RE - NUCLEO_F334R8 - DISCO_F334C8 - DISCO_F303VC
Ports for Upcoming Targets 2669: Added u-blox C029 target ARMmbed/mbed-os#2669 2707: [EFM32] Add IAR support for remaining Silicon Labs targets ARMmbed/mbed-os#2707 2819: MultiTech xDot platform support - 09.26.2016 ARMmbed/mbed-os#2819 2827: include MultiTech xDot in mbed 5 releases ARMmbed/mbed-os#2827 Fixes and Changes 2522: Add CThunk for CM7 ARMmbed/mbed-os#2522 2518: Enable uvisor on Beetle ARMmbed/mbed-os#2518 2571: STM32F7 - Add asynchronous serial ARMmbed/mbed-os#2571 2616: STM32F3xx - Add Serial Flow Control pins + enable it ARMmbed/mbed-os#2616 2619: NUCLEO_L152RE - Add Serial Flow Control ARMmbed/mbed-os#2619 2620: NUCLEO_F429ZI - Add SERIAL_FC macro ARMmbed/mbed-os#2620 2666: [EFM32] Microsecond ticker optimization ARMmbed/mbed-os#2666 2681: STM32F0xx - Add support of ADC internal channels ARMmbed/mbed-os#2681 2687: [NRF5] Add fs_data symbol in data secton for gcc ARMmbed/mbed-os#2687 2696: Add device_has to all nrf51 devices ARMmbed/mbed-os#2696 2703: TARGET_NRF5: Changed 'serial_baud' implementation to support special baud rates. ARMmbed/mbed-os#2703 2704: DISCO_L476VG: add SPI nicknames ARMmbed/mbed-os#2704 2723: KSDK serial_api.c: Fix assertion error for ParityEven ARMmbed/mbed-os#2723 2463: [STM32L0] Add asynchronous serial ARMmbed/mbed-os#2463 2572: Fix STM32F407VG target name and LPC11U6X linker errors ARMmbed/mbed-os#2572 2698: DELTA_DFBM_NQ620 target ARMmbed/mbed-os#2698 2542: Dev spi asynch stm32f4 ARMmbed/mbed-os#2542 2650: STM32F3 - Add low power timer ARMmbed/mbed-os#2650 2415: [STM32F0] Add asynchronous serial ARMmbed/mbed-os#2415 2585: Added support for ADC only pins in LPC43xx ARMmbed/mbed-os#2585 2622: [STM32F4] Add asynchronous I2C ARMmbed/mbed-os#2622 2719: Updated ARM linker scripts for Kinetis platforms that use SDK 2.0 ARMmbed/mbed-os#2719 2728: Added ethernet and enabled IPV4 feature for the EVK-ODIN-W2/C029 target ARMmbed/mbed-os#2728 2747: [LPC11U68] Fix pin interrupt select offset ARMmbed/mbed-os#2747 2751: STM32L0xx - Add Serial Flow Control ARMmbed/mbed-os#2751 2753: [NUCLEO_F767ZI] Add CAN capability ARMmbed/mbed-os#2753 2759: STM32F0 - Add low power timer ARMmbed/mbed-os#2759 2763: STM32L1 - Add low power timer ARMmbed/mbed-os#2763 2764: STM32L4 - Add low power timer ARMmbed/mbed-os#2764 2771: STM32L4 - Update deepsleep implementation ARMmbed/mbed-os#2771 2775: Update KSDK SDHC driver for K64F & K66F ARMmbed/mbed-os#2775 2792: [NUCLEO_F303ZE] MBED-OS5 capability ARMmbed/mbed-os#2792 2762: STM32L0 - Add low power timer ARMmbed/mbed-os#2762 2761: STM32F7 - Add low power timer ARMmbed/mbed-os#2761
This PR add a low power timer implementation for STM32F3 targets.
It also protecthal_tick
from multiple init. (it was reset after a wake up from deepsleep)Concern:
Results
The
1s lp_ticker deepsleep
tests do not pass because on ST targets theus_timer
is stopped during deepsleep but I manually checked the timing with a oscilloscope and I measured 1.00104s (at least with the NUCLEO_F303RE).Even if it can give us some false positives, we could change the test to use
lp_ticker_read()
instead ofus_ticker_read()
. Thelp_ticker_read()
andlp_ticker_set_interrupt()
are already tested by the other tests.@bulislaw I can add a commit, just let me now if you agree.
This is failing on GCC due to this issue GCC - hardfault in mktime with irq disabled #2647
Tests
Edit: I use the wake up timer (instead of alarm in the current F0 implementation) because it make the handle of timestamp overflow easier and the accuracy is equivalent.