Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32: Standard Pin Names #14480

Merged
merged 17 commits into from
Apr 15, 2021
Merged

STM32: Standard Pin Names #14480

merged 17 commits into from
Apr 15, 2021

Conversation

jeromecoutant
Copy link
Collaborator

Summary of changes

This is following #14381

@ARMmbed/team-st-mcd
@MarceloSalazar @gpsimenos

Impact of changes

  • STM32_gen_PeripheralPins.py script: version 1.20
  • targets.json: replacing ARDUINO connector by ARDUINO_UNO
  • targets.json: removing MORPHO connector as it is not used and not useful
  • PinNames.h: updates according to latest standard, done thanks to STM32_gen_PeripheralPins.py script

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Mar 29, 2021
@ciarmcom
Copy link
Member

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team March 29, 2021 07:30
MarceloSalazar
MarceloSalazar previously approved these changes Mar 29, 2021
View reviewed changes
Copy link

@MarceloSalazar MarceloSalazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, it looks good and the pinvalidate.py tests pass!

@mergify mergify bot added needs: CI and removed needs: review labels Mar 29, 2021
@MarceloSalazar MarceloSalazar requested review from a team and removed request for a team March 30, 2021 08:14
@MarceloSalazar
Copy link

FYI @ARMmbed/team-multitech @ARMmbed/team-analogdevices @ARMmbed/team-advantech @ARMmbed/team-uhuru @ARMmbed/team-seeed

@mergify mergify bot dismissed MarceloSalazar’s stale review April 2, 2021 14:08

Pull request has been modified.

@felser
Copy link
Contributor

felser commented Apr 6, 2021

The changes are approved on behalf of MultiTech.

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 6, 2021

CI started

@mergify mergify bot added needs: work and removed needs: CI labels Apr 6, 2021
@mbed-ci
Copy link

mbed-ci commented Apr 6, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ❌
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ❌
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ❌
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️

@jeromecoutant
Copy link
Collaborator Author

@0xc0170 correction done
Could you restart CI ?

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 7, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Apr 7, 2021

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ❌
jenkins-ci/mbed-os-ci_greentea-test ✔️

@jeromecoutant
Copy link
Collaborator Author

Please rebase, I'll restart CI asap

Done

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 15, 2021

CI restarted

@jeromecoutant jeromecoutant mentioned this pull request Apr 15, 2021
Merged
@mbed-ci
Copy link

mbed-ci commented Apr 15, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 6 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 32d1c99 into ARMmbed:master Apr 15, 2021
@mergify mergify bot removed the ready for merge label Apr 15, 2021
@jeromecoutant jeromecoutant deleted the PR_STM32_STANDARD branch April 15, 2021 16:22
@mbedmain mbedmain removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Apr 26, 2021
@ianhattendorf ianhattendorf mentioned this pull request Sep 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@MarceloSalazar MarceloSalazar MarceloSalazar left review comments

Assignees
No one assigned
Labels
devices: st release-version: 6.10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jeromecoutant @ciarmcom @MarceloSalazar @felser @0xc0170 @mbed-ci @LDong-Arm @mbedmain