Standard Pin Names #14381
Merged
Standard Pin Names #14381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gpsimenos, thank you for your changes. |
gpsimenos
force-pushed
the
feature-std-pin-name
branch
from
39188e8
to
21194f5
Compare
|
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
CI restarted |
Jenkins CI Test : ❌ FAILEDBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Jenkins CI Test : ✔️ SUCCESSBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
Travis failure is expected to be red here as any other subsequent PR will be green again. |
| #define MBED_PIN_NAME_ALIASES_H | ||
|
|
||
| /* Aliases for legacy reasons. To be removed in the next Mbed OS version */ | ||
| #if defined (CONSOLE_TX) && (CONSOLE_RX) |
There was a problem hiding this comment.
CONSOLE_TX and CONSOLE_RX are defined as enum,
So #if defined will be always "false"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
This PR introduces standard pin names for Mbed and migrates a number of ST targets to this standard. It also includes compliance testing tools based on static analysis and Greentea tests, and adds target markers to PinNames.h files so that they can be reliably matched to their corresponding target.
Impact of changes
Migration actions required
Documentation
Porting and developer guide in place (waiting for this to be merged)
ARMmbed/mbed-os-5-docs#1417
Pull request type
Test results
Reviewers
@MarceloSalazar @jeromecoutant