Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 usb: fixing missing header file #13846

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Nov 3, 2020

Summary of changes

Fixes #13838. The previous PR #13683 did miss these unfortunately.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| NUCLEO_F103RB-ARMC6 | NUCLEO_F103RB | drivers-tests-tests-usb_device-hid | OK | 22.18 | default |
| NUCLEO_F103RB-ARMC6 | NUCLEO_F103RB | drivers-tests-tests-usb_device-msd | OK | 18.64 | default |

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 3, 2020

CI started

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 3, 2020
@ciarmcom
Copy link
Member

ciarmcom commented Nov 3, 2020

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team November 3, 2020 17:27
@mbed-ci
Copy link

mbed-ci commented Nov 3, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest

@Allmoz
Copy link
Contributor

Allmoz commented Nov 4, 2020

Tested on STM32F103C8T6 and STM32F103RET6, it works for me.

Oh, so the include had to be in USBPhy_STM32.cpp

The use of mbed::DigitalOut usb_dp_pin(USB_DP, 0) ; is conditional, should the include be conditional too? that would be consistent with the spirit of #13683 of reducing the inclusion of libraries when not needed.

#if defined(TARGET_STM32F1)
void USB_reenumerate()
{
    // Force USB_DP pin (with external pull up) to 0
    mbed::DigitalOut usb_dp_pin(USB_DP, 0) ;
    wait_us(10000); // 10ms
}
#endif

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 4, 2020

Thank you both for testing !

@Allmoz yes that would be probably better. I moved it to implementation as that one needed it, so the scope already is reduced.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 4, 2020

Moved the inclusion to where it is needed.

CI restarted

@mbed-ci
Copy link

mbed-ci commented Nov 4, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 4, 2020

@ARMmbed/mbed-os-maintainers Please review

@harmut01
Copy link
Contributor

harmut01 commented Nov 5, 2020

LGTM

@0xc0170 0xc0170 merged commit 61bed01 into ARMmbed:master Nov 5, 2020
@mergify mergify bot removed the ready for merge label Nov 5, 2020
@0xc0170 0xc0170 deleted the fix-stm32-usb-header branch November 5, 2020 14:50
@mbedmain mbedmain added release-version: 6.5.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USBSerial can't work on bluepill (stm32f1c8t6) after Mbedos 6.4.
7 participants