-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
STM32 usb: fixing missing header file #13846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| NUCLEO_F103RB-ARMC6 | NUCLEO_F103RB | drivers-tests-tests-usb_device-hid | OK | 22.18 | default |
| NUCLEO_F103RB-ARMC6 | NUCLEO_F103RB | drivers-tests-tests-usb_device-msd | OK | 18.64 | default |
CI started |
@0xc0170, thank you for your changes. |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Tested on STM32F103C8T6 and STM32F103RET6, it works for me. Oh, so the include had to be in USBPhy_STM32.cpp The use of
|
Thank you both for testing ! @Allmoz yes that would be probably better. I moved it to implementation as that one needed it, so the scope already is reduced. |
88d5804
to
097adb5
Compare
Moved the inclusion to where it is needed. CI restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
@ARMmbed/mbed-os-maintainers Please review |
LGTM |
Summary of changes
Fixes #13838. The previous PR #13683 did miss these unfortunately.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers