-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USB STM32: fix header inclusion, removing mbed.h #13683
Conversation
@0xc0170, thank you for your changes. |
@adbridge Please review. I'll start CI meanwhile |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
Failures are related, I'll review and I'll fix |
d87aa7e
to
e56d429
Compare
Pull request has been modified.
Updated, I've missed one C library header file. restarting CI |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
@0xc0170 |
@jeromecoutant Not yet, I can fix it now |
@Allmoz feel free to send a pull request if you find a bug like this. I'll fix it now as proposed |
Summary of changes
Fixes #13667 issue. I tested locally a built with disco iot board (but with CMake not to have extra code in), did not have compilation errors.
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers