Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB STM32: fix header inclusion, removing mbed.h #13683

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Sep 30, 2020

Summary of changes

Fixes #13667 issue. I tested locally a built with disco iot board (but with CMake not to have extra code in), did not have compilation errors.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@0xc0170 0xc0170 changed the title USB STM32: fix header inclusion, removing mbed.h' USB STM32: fix header inclusion, removing mbed.h Sep 30, 2020
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 30, 2020
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team September 30, 2020 08:00
@0xc0170 0xc0170 requested a review from a team September 30, 2020 08:41
@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 13, 2020

@adbridge Please review. I'll start CI meanwhile

@mbed-ci
Copy link

mbed-ci commented Oct 13, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM
jenkins-ci/mbed-os-ci_build-ARM ✔️

adbridge
adbridge previously approved these changes Oct 13, 2020
@mergify mergify bot added needs: CI and removed needs: work labels Oct 13, 2020
@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 13, 2020

Failures are related, I'll review and I'll fix

@0xc0170
Copy link
Contributor Author

0xc0170 commented Oct 13, 2020

Updated, I've missed one C library header file. restarting CI

@mbed-ci
Copy link

mbed-ci commented Oct 15, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@jeromecoutant
Copy link
Collaborator

and since is now not using mbed namespace, it needs to be added into line 181 of USBPhyHw.h like:

@0xc0170
Did you check this ?

@0xc0170 0xc0170 deleted the fix_stm32_usb branch November 3, 2020 11:14
@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 3, 2020

@jeromecoutant Not yet, I can fix it now

@0xc0170
Copy link
Contributor Author

0xc0170 commented Nov 3, 2020

@Allmoz feel free to send a pull request if you find a bug like this.

I'll fix it now as proposed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STM32 usb: includes mbed.h file
7 participants