-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
targets:RT1050: Fix the flash erase and program issue for qspi nor fl… #13569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Tim-Wang38, thank you for your changes. |
fredlee12001
reviewed
Sep 9, 2020
@@ -509,7 +509,7 @@ status_t flexspi_nor_flash_page_program_ram(uint32_t address, const uint32_t *sr | |||
flashXfer.cmdType = kFLEXSPI_Write; | |||
flashXfer.SeqNumber = 1; | |||
flashXfer.seqIndex = NOR_CMD_LUT_SEQ_IDX_PAGEPROGRAM_QUAD; | |||
flashXfer.data = (uint32_t *)(src + offset); | |||
flashXfer.data = (uint32_t *)((uint32_t)src + offset); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest to add same fix to HyperFlash part.
…ash. Update the LUT to fix the winbond qspi flash erase issue. Update the page program interface to fix the qspi flash program issue. Signed-off-by: Tim Wang <[email protected]>
Tim-Wang38
force-pushed
the
feature-wisun
branch
from
September 9, 2020 06:57
7442be9
to
7e80d3a
Compare
0xc0170
approved these changes
Sep 9, 2020
fredlee12001
approved these changes
Sep 11, 2020
teetak01
approved these changes
Sep 11, 2020
artokin
approved these changes
Sep 11, 2020
@ARMmbed/mbed-os-maintainers , would you please start the CI run for this? |
CI started |
Test run: SUCCESSSummary: 10 of 10 test jobs passed |
This was referenced Feb 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ash.
Update the LUT to fix the winbond qspi flash erase issue.
Update the page program interface to fix the qspi flash program issue.
Signed-off-by: Tim Wang [email protected]
Summary of changes
Fix the flash erase and program issue for qspi nor flash.
Impact of changes
No
Migration actions required
No
Documentation
No
Pull request type
Test results
Reviewers