Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

targets:RT1050: Fix the flash erase and program issue for qspi nor fl… #13569

Merged
merged 1 commit into from
Sep 11, 2020

Conversation

Tim-Wang38
Copy link
Contributor

…ash.

Update the LUT to fix the winbond qspi flash erase issue.
Update the page program interface to fix the qspi flash program issue.

Signed-off-by: Tim Wang [email protected]

Summary of changes

Fix the flash erase and program issue for qspi nor flash.

Impact of changes

No

Migration actions required

No

Documentation

No

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


@ciarmcom
Copy link
Member

ciarmcom commented Sep 8, 2020

@Tim-Wang38, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@@ -509,7 +509,7 @@ status_t flexspi_nor_flash_page_program_ram(uint32_t address, const uint32_t *sr
flashXfer.cmdType = kFLEXSPI_Write;
flashXfer.SeqNumber = 1;
flashXfer.seqIndex = NOR_CMD_LUT_SEQ_IDX_PAGEPROGRAM_QUAD;
flashXfer.data = (uint32_t *)(src + offset);
flashXfer.data = (uint32_t *)((uint32_t)src + offset);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to add same fix to HyperFlash part.

…ash.

Update the LUT to fix the winbond qspi flash erase issue.
Update the page program interface to fix the qspi flash program issue.

Signed-off-by: Tim Wang <[email protected]>
@artokin
Copy link
Contributor

artokin commented Sep 11, 2020

@ARMmbed/mbed-os-maintainers , would you please start the CI run for this?

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 11, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants