Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PSoC 6 BSP Targets #11323

Closed

Conversation

kyle-cypress
Copy link

@kyle-cypress kyle-cypress commented Aug 24, 2019

Description

Restructure PSoC6 target contents for improved maintainability.
Misc updates to board configuration firmware.
This PR is dependent on #11321 and #11324

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-cypress

Release Notes

@ciarmcom
Copy link
Member

@kyle-cypress, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team August 25, 2019 01:01
@0xc0170 0xc0170 requested a review from a team August 26, 2019 09:49
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 26, 2019

Ci started

@mbed-ci
Copy link

mbed-ci commented Aug 26, 2019

Test run: FAILED

Summary: 3 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-IAR
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-GCC_ARM

@kyle-cypress
Copy link
Author

This PR is dependent on #11321 and #11324

Kyle Kearney added 6 commits August 27, 2019 15:09
This avoids a stack overflow if sleep is called for the first time from
the idle thread (which by default has a fairly small stack, and which is
already fairly deep by the time it calls into the usticker adapter)
Enables code examples/end user applications to override if necessary
Add BSP_DESIGN_MODUS component by default to all PSOC6 boards. Applications can remove this if necessary.
For kit targets that inherit from a module, move the kit a top-level
target folder rather than nesting underneath the module folder, to
avoid too-long-path issues on Windows.
Note this only changes the folder layout, not the inheritance.
Include all configurator design files with each BSP
Only include the CM4 startup code and linker scripts with the target for each board.
@0xc0170
Copy link
Contributor

0xc0170 commented Aug 28, 2019

@kyle-cypress To simplify the integration as we lost some time due to internal CI issues. I can see this one needs rebase and others might need also. Lets do a rollup PR - one PR including all "needs: CI" Prs related to PSOC6.

Few PRs were already reviewed and approved. Can you create one PR integrating these dependancies together and reference what PRs are included (we can run one CI job to test it instead of 5x running). That PR would close automatically all of these. Let us know.

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 29, 2019

Integrated via #11367

@0xc0170 0xc0170 closed this Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants