JNI wrapper for Rust's BTreeMap #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark for 631e1f4Click to view benchmark
|
Benchmark for 1cd61bcClick to view benchmark
|
Benchmark for b700370Click to view benchmark
|
Benchmark for 2b2d16eClick to view benchmark
|
Pushkarm029
requested review from
tareknaser,
twitu and
kirillt
and removed request for
twitu
|
resolving merge conflicts |
twitu
requested changes
Jun 23, 2024
There was a problem hiding this comment.
We want to wrap the underlying BTreeMap in the FileStorage. We want the BTreeMap to be accessible independent of the FileStorage.
This will most likely lead to a design where the BTreeMap is wrapped like Rc<RefCell<BTreeMap>>. This can then be put in a separate struct called
struct WrapperBTreeMap {
data: Rc<RefCell<BTreeMap>>
}
We can then expose Java get and iterator functions for this.
The current approach is tightly coupled with the FileStorage implementation and will not scale to other BaseStorage implementations like FolderStorage and ChunkedStorage.
Note: That Rc RefCell will work with us till we add async at which points we'll switch to Arc Mutex.
Benchmark for 81d2ac1Click to view benchmark
|
Benchmark for cca9b6eClick to view benchmark
|
Benchmark for dd5700dClick to view benchmark
|
Signed-off-by: pushkarm029 <[email protected]>
Benchmark for 8e69a0fClick to view benchmark
|
Signed-off-by: pushkarm029 <[email protected]>
Signed-off-by: pushkarm029 <[email protected]>
Benchmark for 750678cClick to view benchmark
|
Benchmark for f4761efClick to view benchmark
|
tareknaser
reviewed
Jul 2, 2024
twitu
approved these changes
Jul 4, 2024
There was a problem hiding this comment.
Looks good to merge once @tareknaser's comments are resolved.
|
ok, working on it |
Signed-off-by: pushkarm029 <[email protected]>
Benchmark for bb4aa20Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #70