Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a JNI wrapper for Rust's BTreeMap #70

Closed
twitu opened this issue Jun 9, 2024 · 0 comments · Fixed by #76
Closed

Create a JNI wrapper for Rust's BTreeMap #70

twitu opened this issue Jun 9, 2024 · 0 comments · Fixed by #76
Assignees

Comments

@twitu
Copy link
Collaborator

twitu commented Jun 9, 2024

Originally posted by @kirillt in #61 (comment)

Currently, the FileStorage JNI bindings perform an expensive conversion to return the whole key-value mapping. However, it can be made more efficient by keeping the BTreeMap on the rust side and exposing functions on it that mimic the relevant operations of a Mapping on the Java side.

Note: We only want to expose read only operations because any write related operations should go through the FileStorage functions.

So methods for getting a value for a key and iterating key value pairs will be a good starting point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants