Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of Agroforestry Model #56

Closed
fainges opened this issue Apr 24, 2015 · 25 comments
Closed

Addition of Agroforestry Model #56

fainges opened this issue Apr 24, 2015 · 25 comments
Assignees

Comments

@fainges
Copy link
Contributor

fainges commented Apr 24, 2015

An agroforestry model is required. Implementation will be by Neil Huth and Justin Fainges. The implementation will involve the creation of a multi-Zone aware tree model and associated GUI.

@hol353 hol353 added the Major label Apr 30, 2015
@fainges
Copy link
Contributor Author

fainges commented Jul 2, 2015

Moved model to Prototypes directory.

@hol353
Copy link
Contributor

hol353 commented Apr 10, 2019

This is the initial reviewers report by Michael Battaglia dated 30th August 2016
Agroforestry_System_Model_APSIM_ReviewersReport_v1 3.zip

@sarahcleary
Copy link
Contributor

@hut104 - can you please provide an update on where this is at?

@sarahcleary
Copy link
Contributor

@hol353 to discuss progress with @hut104

@hol353
Copy link
Contributor

hol353 commented Jan 29, 2020

I'm happy for Agroforestry to be included in the release.

@jbrider
Copy link
Contributor

jbrider commented Jan 29, 2020 via email

@sarahcleary
Copy link
Contributor

@APSIMInitiative/reference-panel - still awaiting approval from AgR and USQ

@LouisAK
Copy link

LouisAK commented Feb 3, 2020

Approved

@sno036
Copy link
Contributor

sno036 commented Feb 3, 2020

I will try to look at this before the meeting but tomorrow is pretty packed - might be later in the week

@sarahcleary
Copy link
Contributor

@sno036 - just a reminder we are awaiting AgR's approval.

1 similar comment
@sarahcleary
Copy link
Contributor

@sno036 - just a reminder we are awaiting AgR's approval.

@sno036
Copy link
Contributor

sno036 commented Feb 26, 2020

@hut104 - sorry - I don't think this is ready for release. I'm very interested to have a good look at it but it needs documentation.

I can't see any documentation (which is a problem to begin with),
I opened the Single Tree Example simulation:
• the last parameter on the zone has a spelling error and the unit is obscure (H = multiples of height? I assume. But it needs some explanation)
• Having rainfall interception as a straight fraction of rainfall is a really bad idea – the fraction should be relatively large for small rainfall events but small for large rainfall events – there is a maximum interception possible. Or is this supposed to be stemflow or something? Either way I think it needs some more work (even if it just relabeling as stemflow) (and some documentation).

  • I didn't investigate much further because there wasn't any documentation so I didn't know what I was doing.

@sarahcleary
Copy link
Contributor

Any update @hut104?

@hut104
Copy link
Contributor

hut104 commented Mar 31, 2020 via email

@sarahcleary
Copy link
Contributor

@hol353 - where is this at?

@hol353
Copy link
Contributor

hol353 commented Apr 1, 2020

Looks like this has made it into release but it can still be improved upon. The documentation seems to be fixed and is available on the web site.

@sarahcleary
Copy link
Contributor

@sno036 - I assume this can be removed from the RP agenda? please let me know if it needs further discussion

@sarahcleary
Copy link
Contributor

In Release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Release
Development

No branches or pull requests

8 participants