Fix: Don't add persistent home volume if workspace doesn't require pe…

…rsistent storage Fix devfile#1203 Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow · Nov 23, 2023 · 33a124b · 33a124b
1 parent 1a818a3
commit 33a124b
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/controllers/workspace/devworkspace_controller.go b/controllers/workspace/devworkspace_controller.go
@@ -291,7 +291,7 @@ func (r *DevWorkspaceReconciler) Reconcile(ctx context.Context, req ctrl.Request
 		return r.failWorkspace(workspace, fmt.Sprintf("Error provisioning storage: %s", err), metrics.ReasonBadRequest, reqLogger, &reconcileStatus), nil
 	}
 
-	if home.NeedsPersistentHomeDirectory(workspace) {
+	if storageProvisioner.NeedsStorage(&workspace.Spec.Template) && home.NeedsPersistentHomeDirectory(workspace) {
 		workspaceWithHomeVolume, err := home.AddPersistentHomeVolume(workspace)
 		if err != nil {
 			reconcileStatus.addWarning(fmt.Sprintf("Info: default persistentHome volume is not being used: %s", err.Error()))