Fix: persistent home volume name should not use capital letters

Fix devfile#1200 Signed-off-by: Andrew Obuchowicz <[email protected]>
AObuchow · Nov 23, 2023 · 1a818a3 · 1a818a3
1 parent 093bb40
commit 1a818a3
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/pkg/constants/constants.go b/pkg/constants/constants.go
@@ -39,7 +39,7 @@ const (
 
 	HomeUserDirectory = "/home/user/"
 
-	HomeVolumeName = "persistentHome"
+	HomeVolumeName = "persistent-home"
 
 	ServiceAccount = "devworkspace"
 

diff --git a/pkg/library/home/testdata/persistent-home/creates-home-vm-when-enabled.yaml b/pkg/library/home/testdata/persistent-home/creates-home-vm-when-enabled.yaml
@@ -26,9 +26,9 @@ output:
           volumeMounts:
             - name: my-defined-volume
               path: /my-defined-volume-path
-            - name: persistentHome
+            - name: persistent-home
               path: /home/user/
       - name: my-defined-volume
         volume: {}
-      - name: persistentHome
+      - name: persistent-home
         volume: {}
diff --git a/pkg/library/home/testdata/persistent-home/noop-if-home-vm-name-used.yaml b/pkg/library/home/testdata/persistent-home/noop-if-home-vm-name-used.yaml
@@ -1,4 +1,4 @@
-name: "Does not create persistent home volume if a volume already named 'persistentHome'"
+name: "Does not create persistent home volume if a volume is already named 'persistent-home'"
 
 input:
   devworkspaceId: "test-workspaceid"
@@ -14,7 +14,7 @@ input:
           volumeMounts:
             - name: my-defined-volume
               path: /my-defined-volume-path
-            - name: persistentHome
+            - name: persistent-home
               path: /some/path
       - name: testing-container-2
         container:
@@ -24,11 +24,11 @@ input:
               path: /my-defined-volume-path
       - name: my-defined-volume
         volume: {}
-      - name: persistentHome
+      - name: persistent-home
         volume: {}
 
 output:
-  error: "addition of persistentHome volume would render DevWorkspace invalid: 1 error occurred:\n\t* duplicate key: persistentHome\n\n"
+  error: "addition of persistent-home volume would render DevWorkspace invalid: 1 error occurred:\n\t* duplicate key: persistent-home\n\n"
   workspace:
     components:
       - name: testing-container-1
@@ -37,7 +37,7 @@ output:
           volumeMounts:
             - name: my-defined-volume
               path: /my-defined-volume-path
-            - name: persistentHome
+            - name: persistent-home
               path: /some/path
       - name: testing-container-2
         container:
@@ -47,5 +47,5 @@ output:
               path: /my-defined-volume-path
       - name: my-defined-volume
         volume: {}
-      - name: persistentHome
+      - name: persistent-home
         volume: {}