New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port InitRandom for pure SoA #3325

Merged

atmyers merged 4 commits into AMReX-Codes:development from atmyers:initrandompuresoa

May 23, 2023

Member

atmyers commented May 23, 2023 •

edited by ax3l

Loading

This is useful for porting and testing other features, like Checkpoint / Restart. I've also added a test.

Follow-up to #2878.

The proposed changes:

fix a bug or incorrect behavior in AMReX
add new capabilities to AMReX
changes answers in the test suite to more than roundoff level
are likely to significantly affect the results of downstream AMReX users
include documentation in the code and/or rst files, if appropriate


          Port InitRandom for pure SoA

e6af49c

atmyers requested a review from ax3l

May 23, 2023 02:05

atmyers added 2 commits

May 22, 2023 19:08


          Merge branch 'development' into initrandompuresoa

e4450cf


          new cmake stuff

5c39c9a

github-advanced-security bot found potential problems

View reviewed changes

github-advanced-security bot left a comment

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.


          remove unused

ae46cb4

ax3l mentioned this pull request

SoA: InitRandom/OnePerCell #3280

Open

9 tasks

ax3l self-assigned this

ax3l added the enhancement label

ax3l approved these changes

View reviewed changes

Member

ax3l left a comment

Thank you! :)

github-advanced-security bot found potential problems

View reviewed changes

Tests/Particles/InitRandom/main.cpp

+                  }
+                  // Add some particles
+                  constexpr int NStructReal = 4;

Check notice

Code scanning / CodeQL

Unused local variable

Variable NStructReal is not used.

Tests/Particles/InitRandom/main.cpp

+                  // Add some particles
+                  constexpr int NStructReal = 4;
+                  constexpr int NStructInt  = 1;

Check notice

Code scanning / CodeQL

Unused local variable

Variable NStructInt is not used.

Tests/Particles/InitRandom/main.cpp

+                  // Add some particles
+                  constexpr int NStructReal = 4;
+                  constexpr int NStructInt  = 1;
+                  constexpr int NArrayReal  = 8;

Check notice

Code scanning / CodeQL

Unused local variable

Variable NArrayReal is not used.

Tests/Particles/InitRandom/main.cpp

+                  constexpr int NStructReal = 4;
+                  constexpr int NStructInt  = 1;
+                  constexpr int NArrayReal  = 8;
+                  constexpr int NArrayInt   = 3;

Check notice

Code scanning / CodeQL

Unused local variable

Variable NArrayInt is not used.

Tests/Particles/InitRandom/main.cpp

+                  }
+                  // Add some particles
+                  constexpr int NReal  = 12;

Check notice

Code scanning / CodeQL

Unused local variable

Variable NReal is not used.

Tests/Particles/InitRandom/main.cpp

+                  // Add some particles
+                  constexpr int NReal  = 12;
+                  constexpr int NInt   = 4;

Check notice

Code scanning / CodeQL

Unused local variable

Variable NInt is not used.

ax3l mentioned this pull request

[WIP] ParticleContainer: More Pure SoA Init Functions AMReX-Codes/pyamrex#125

Open

2 tasks

atmyers enabled auto-merge (squash)

May 23, 2023 03:41

atmyers merged commit 4167cbe into AMReX-Codes:development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels