SoA: InitRandom/OnePerCell #3280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
ax3l
force-pushed
the
topic-soa-init-particle
branch
from
3ca6008
to
8aec382
Compare
ax3l
commented
May 26, 2023
ax3l
force-pushed
the
topic-soa-init-particle
branch
8 times, most recently
from
a2420d6
to
0d800a5
Compare
ax3l
commented
May 30, 2023
| p.pos(0) = static_cast<ParticleReal>(grid_box.lo(0) + (dist(mt) + icnt) / icount_per_box * grid_box.length(0)); | ||
| p.pos(1) = static_cast<ParticleReal>(grid_box.lo(1) + (dist(mt) + jcnt) / icount_per_box * grid_box.length(1)); | ||
| p.pos(2) = static_cast<ParticleReal>(grid_box.lo(2) + (dist(mt) + kcnt) / icount_per_box * grid_box.length(2)); | ||
| // the position data |
There was a problem hiding this comment.
I think InitRandomPerBox needs a bigger rewrite.
ax3l
force-pushed
the
topic-soa-init-particle
branch
from
0d800a5
to
54d0623
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -60,8 +60,8 @@ | |||
| } | |||
|
|
|||
| // Add some particles | |||
| constexpr int NReal = 12; | |||
| constexpr int NInt = 4; | |||
| constexpr int NReal = AMREX_SPACEDIM + 12; | |||
Check notice
Code scanning / CodeQL
Unused local variable
| constexpr int NReal = 12; | ||
| constexpr int NInt = 4; | ||
| constexpr int NReal = AMREX_SPACEDIM + 12; | ||
| constexpr int NInt = 2 + 4; |
Check notice
Code scanning / CodeQL
Unused local variable
ax3l
changed the title
Support more init methods on SoA particle containers.
ax3l
force-pushed
the
topic-soa-init-particle
branch
from
54d0623
to
d2aa914
Compare
|
@atmyers @AlexanderSinn ready to review & merge :) This should help with #3290
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Support more init methods on SoA particle containers.
ParticleInitDataInitOnePerCellInitRandomPort InitRandom for pure SoA #3325InitRandomPerBoxAdditional background
Follow-up to #2878.
Needed for AMReX-Codes/pyamrex#124
Checklist
The proposed changes: