Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New translations 16 Oct 2023 #182

Closed
scy opened this issue Oct 16, 2023 · 13 comments · Fixed by #191
Closed

New translations 16 Oct 2023 #182

scy opened this issue Oct 16, 2023 · 13 comments · Fixed by #191
Assignees
@scy
Labels
area:orga Organizational & management flag:help wanted Could use someone else to support prio:B Major impact, but not essential type:enhancement New feature or request
Milestone
4.0: public release

Comments

@scy
Copy link
Collaborator

scy commented Oct 16, 2023 •
edited
Loading

This issue exists to guide volunteers to provide translations for several new text snippets in frontend & backend, as well as provide an overview over what needs to be done and what has been done.

Languages requested

We need translations for French, Danish, Portuguese and Swedish. Please create a new branch for your language (and name it translation-XX-16-oct-23, with XX being your language code), do your translations there, and open a pull request for it. Mention this issue (#182) in the PR’s description so that it will be linked here.

Changes requested

The frontend texts call.home.descriptions.0.text and call.home.descriptions.1.text have been modified in English & German, the other languages should follow.

The Data Protection Policy has been slightly changed, please modify your translated version accordingly (English & German are done already):

image

In French and Portuguese, the phone_number_verification_sms translation does not start with {code}. This is not a big issue, but if the {code} is not placed at the beginning, it might be cut off from the notification popup the User will receive on their mobile phone, forcing them to open their SMS app to be able to read it. It’s therefore considered best practice to start the message with the code, even if it sounds slightly strange. Please update the translation in these two languages.

New strings

You’ve done this before: We collect the translations in server/dearmep/example-config.yaml. You can simply scroll through the file and check where new translations are required, or use this list. The following strings are new:

  • in the backend section (strings):
    • feedback_survey_sms
  • in the frontend section (frontend_strings):
    • call.call-now-btn.outOfOfficeHoursHint
    • call.office-hours.title
    • call.office-hours.description
    • call.office-hours.hours-zoned
    • call.office-hours.hours
    • call.office-hours.day-range
    • call.office-hours.time-range-zoned
    • call.office-hours.time-range
    • call.office-hours.time-zone-local
    • call.home.titleAuthenticated
    • call.home.youHaveAlreadySignedIn
    • verification.enterNumber.numberIsRequired
    • verification.enterNumber.invalidNumber
    • verification.enterNumber.numberNotAllowed
    • verification.enterNumber.numberBlocked
    • verification.enterNumber.tooManyAttempts
    • verification.enterNumber.policyLinkUrl
    • verification.enterCode.invalidCode
    • callSetup.error.failedToEstablishCall
    • callSetup.error.failedToReachDestination
    • callSetup.error.outsideOfficeHours
    • feedback.skip
    • feedback.alreadySubmitedError
    • error.genericApiError
    • errro.genericError
    • error.errorDialogTitle
    • error.errorDialogOK

Languages completed
@scy scy added type:enhancement New feature or request prio:B Major impact, but not essential area:orga Organizational & management labels Oct 16, 2023
@scy scy added this to the 2.0: instant call support milestone Oct 16, 2023
@scy scy self-assigned this Oct 16, 2023
@scy scy mentioned this issue Oct 16, 2023
Closed
@scy scy pinned this issue Oct 16, 2023
@scy scy changed the title New translations Oct 2023 New translations 16 Oct 2023 Oct 16, 2023
@scy
Copy link
Collaborator Author

scy commented Oct 16, 2023

Hey @auracles @hugopeixoto @jbethune @muminpappa, we could use some more translations (French, Portuguese, Danish & Swedish). A few text snippets have changed, some new ones have appeared. Please check out this issue’s description for a detailed overview and how you could help us out.

As we are planning to go live with the tool possibly this Wednesday already, we’d be really happy if you could do the translation as soon as possible. But, no pressure, if you can’t make it then we’ll launch with the old versions or fall back to English. If you don’t have time to help us out right now, please just let us know so that we can try looking for someone else.

@muminpappa muminpappa mentioned this issue Oct 17, 2023
Merged
@scy scy mentioned this issue Oct 17, 2023
Merged
@hugopeixoto hugopeixoto mentioned this issue Oct 17, 2023
Merged
@jbethune
Copy link
Collaborator

jbethune commented Oct 17, 2023 •
edited
Loading

I'm waiting for #191 to be merged, before I push the danish version.

Late edit: Note about the closing event that is listed next: Seems like the Portugese translation had a close-issue association, which is wrong, because that's only a partial solution.

jbethune added a commit that referenced this issue Oct 17, 2023
@jbethune
Update danish language strings
e670c55 
In support for #182

I've followed the swedish translations as closely as reasonable.
I also updated the strings for for call.home.description.[0,1]
@jbethune jbethune mentioned this issue Oct 17, 2023
Merged
@scy
Copy link
Collaborator Author

scy commented Oct 17, 2023

Nonsense, this is not finished.

@scy scy reopened this Oct 17, 2023
auracles added a commit that referenced this issue Oct 22, 2023
@auracles
Update fr.md #182
cac7cb4 
translated and changed indicated paragraphs
@auracles
Copy link
Collaborator

it's a bit late now but I translated the changed paragraphs of the privacy policy mentioned above

@jbethune
Copy link
Collaborator

Linking #219 for the french translation

scy added a commit that referenced this issue Nov 3, 2023
@scy
Merge pull request #219 from AKVorrat/translation-fr-22-oct-23
854f512 
Update fr.md #182
@scy scy unpinned this issue Dec 12, 2024
@scy
Copy link
Collaborator Author

scy commented Dec 15, 2024

The only thing missing here are the following French translations:

  • call.call-now-btn.outOfOfficeHoursHint
  • call.office-hours.title
  • call.office-hours.description
  • call.office-hours.hours-zoned
  • call.office-hours.day-range
  • call.office-hours.time-range-zoned
  • call.office-hours.time-range
  • call.office-hours.time-zone-local
  • call.home.titleAuthenticated
  • call.home.youHaveAlreadySignedIn
  • verification.enterNumber.numberIsRequired
  • verification.enterNumber.invalidNumber
  • verification.enterNumber.numberNotAllowed
  • verification.enterNumber.numberBlocked
  • verification.enterNumber.tooManyAttempts
  • verification.enterNumber.policyLinkUrl
  • verification.enterCode.invalidCode
  • callSetup.error.failedToEstablishCall
  • callSetup.error.failedToReachDestination
  • callSetup.error.outsideOfficeHours
  • feedback.skip
  • feedback.alreadySubmitedError
  • error.genericApiError
  • errro.genericError
  • error.errorDialogTitle
  • error.errorDialogOK
  • feedback_survey_sms

@scy scy removed their assignment Dec 15, 2024
@scy scy added the flag:help wanted Could use someone else to support label Dec 15, 2024
@auracles
Copy link
Collaborator

The only thing missing here are the following French translations:

  • call.call-now-btn.outOfOfficeHoursHint
  • call.office-hours.title
  • call.office-hours.description
  • call.office-hours.hours-zoned
  • call.office-hours.day-range
  • call.office-hours.time-range-zoned
  • call.office-hours.time-range
  • call.office-hours.time-zone-local
  • call.home.titleAuthenticated
  • call.home.youHaveAlreadySignedIn
  • verification.enterNumber.numberIsRequired
  • verification.enterNumber.invalidNumber
  • verification.enterNumber.numberNotAllowed
  • verification.enterNumber.numberBlocked
  • verification.enterNumber.tooManyAttempts
  • verification.enterNumber.policyLinkUrl
  • verification.enterCode.invalidCode
  • callSetup.error.failedToEstablishCall
  • callSetup.error.failedToReachDestination
  • callSetup.error.outsideOfficeHours
  • feedback.skip
  • feedback.alreadySubmitedError
  • error.genericApiError
  • errro.genericError
  • error.errorDialogTitle
  • error.errorDialogOK
  • feedback_survey_sms

I’ll take care of the French translations within the next week!

@scy
Copy link
Collaborator Author

scy commented Dec 15, 2024

Sorry @auracles, that wasn't meant as a passive-aggressive "we still need this from you…!", but just as a summary/recap, as we're planning to release an open source version soon. More like "we should try getting these couple of messages translated by someone until then". But if you'd like to help us out again, I'd appreciate it a lot :)

@auracles
Copy link
Collaborator

no worries! I didn’t take it that way, apologies if my reply came across this way.
I just saw this thread now and thought I would like to do that so. help is appreciated but I really don’t mind doing this on my own, on the contrary, I’d be happy to help! sorry for not being available lately.

is the deadline ‘end of the week’ alright or do you need the translation sooner?

@scy
Copy link
Collaborator Author

scy commented Dec 16, 2024

no worries! I didn’t take it that way, apologies if my reply came across this way.

It didn't, it's all good :)

help is appreciated

Depending on to what degree you'd like to use Git, it's one of these:

  • download https://github.com/AKVorrat/dearmep/blob/main/server/dearmep/example-config.yaml using the "download raw file" button on the right, add the translations, send them to me, or
  • instead of the download button, use the edit button, add the translations there, click "commit changes" and in the dialog that pops up, create a new branch and start a pull request, or
  • do it on your local machine by cloning the repo, starting a new branch, pushing that and creating a pull request.

I'd probably recommend the second option, but it's up to you really, and if you need any more help, let me know. :)

The translations in the YAML file can all be found under strings. For example, verification.enterNumber.numberIsRequired is here. Sometimes there are comments above the block explaining what the text is used for. Just add a line with fr: and your translation, just like the other languages did.

sorry for not being available lately.

Nothing to be sorry for, we're thankful for your contribution.

is the deadline ‘end of the week’ alright or do you need the translation sooner?

Thursday would be great, because I'd like to package and test the release on Friday, but if you can't make that, just let me know and I'll prepare to get the French translations as a late addition, no big deal. Thanks again!

@auracles
Copy link
Collaborator

Thursday would be great [...]
Done, the pull request should be there :)

Thanks a lot for testing and happy holidays (everyone)!

@scy
Copy link
Collaborator Author

scy commented Dec 19, 2024

Awesome, thanks so much :) Happy holidays to you too!

@scy scy self-assigned this Dec 19, 2024
@scy
Copy link
Collaborator Author

scy commented Dec 19, 2024

With the French translations added, I've reduced the only two "missing" ones to warnings instead of errors in #300:

  • maintenance.message is not translated into sv, da, pt
  • verification.enterNumber.policyLinkUrl is not translated into da

It doesn't make a lot of sense to contact translators just for the maintenance message (that might change on short notice anyway), and the privacy policy URL is only translated if we have an up-to-date privacy policy for that language.

I think this issue can be considered done. Thanks again for everyone who contributed.

@scy scy closed this as completed Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scy scy

Labels
area:orga Organizational & management flag:help wanted Could use someone else to support prio:B Major impact, but not essential type:enhancement New feature or request
Projects
None yet
Milestone
4.0: public release
Development

Successfully merging a pull request may close this issue.

Update Portuguese translations AKVorrat/dearmep
3 participants
@scy @jbethune @auracles