-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#110 fix : 헤더 진행률 & 알람 종류 추가 #111
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,7 +20,7 @@ import DeleteButton from './DeleteButton'; | |
import { TItems, TItemStatus } from '../utils/columnsConfig'; | ||
import useItems from '../hooks/useItems'; | ||
import { BlockListResDto } from '../types/PersonalBlock'; | ||
import { useDebounce } from '../hooks/useDebounce'; | ||
import { useSSE } from '../hooks/useSSE'; | ||
|
||
type PageState = { | ||
todo: number; // 할 일 페이지 번호 | ||
|
@@ -48,8 +48,9 @@ const PersonalDashBoard = () => { | |
hasMoreInProgress, | ||
fetchNextCompleted, | ||
hasMoreCompleted, | ||
blockTotal, | ||
setBlockTotal, | ||
} = useItems(dashboardId, page, location.pathname); | ||
// console.log(items); | ||
|
||
const { data: PersonalDashboardInfo } = useQuery({ | ||
queryKey: ['PersonalDashboardInfo', dashboardId], | ||
|
@@ -142,6 +143,35 @@ const PersonalDashBoard = () => { | |
updateState(destinationKey, sourceKey, targetItem); | ||
} | ||
|
||
//시작점 상태에서 종착지가 시작점 상태와는 다른 상태일때 그 아이템 개수 -1 | ||
if (source.droppableId === 'todo' && destination.droppableId !== 'todo') | ||
setBlockTotal(prev => ({ | ||
...prev, | ||
todo: blockTotal.todo - 1, | ||
[destination.droppableId]: | ||
blockTotal[destination.droppableId as keyof typeof blockTotal] + 1, | ||
})); | ||
else if (source.droppableId === 'doing' && destination.droppableId !== 'doing') | ||
setBlockTotal(prev => ({ | ||
...prev, | ||
doing: blockTotal.doing - 1, | ||
[destination.droppableId]: | ||
blockTotal[destination.droppableId as keyof typeof blockTotal] + 1, | ||
})); | ||
else if (source.droppableId === 'completed' && destination.droppableId !== 'completed') | ||
setBlockTotal(prev => ({ | ||
...prev, | ||
completed: blockTotal.completed - 1, | ||
[destination.droppableId]: | ||
blockTotal[destination.droppableId as keyof typeof blockTotal] + 1, | ||
})); | ||
else if (source.droppableId === 'delete' && destination.droppableId !== 'delete') | ||
setBlockTotal(prev => ({ | ||
...prev, | ||
delete: blockTotal.completed - 1, | ||
[destination.droppableId]: | ||
blockTotal[destination.droppableId as keyof typeof blockTotal] + 1, | ||
})); | ||
Comment on lines
+146
to
+174
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
위와 같이 중복되는 부분을 함수로 분리하면 더 간결하게 작성할 수 있을 것 같아요! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 조언 감사합니다! |
||
updateOrder(_items); | ||
}; | ||
|
||
|
@@ -151,8 +181,8 @@ const PersonalDashBoard = () => { | |
<Header | ||
mainTitle={PersonalDashboardInfo?.title || ''} | ||
subTitle={PersonalDashboardInfo?.description || ''} | ||
blockProgress={(Math.floor(PersonalDashboardInfo?.blockProgress ?? 0) * 10) / 10} | ||
dashboardType={true} | ||
blockTotal={blockTotal} | ||
/> | ||
<DragDropContext onDragEnd={onDragEnd}> | ||
<S.CardContainer> | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
파라미터로 1은 왜 전달하는지 궁금합니다!~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아 저게 소수점 밑에 1자리 수로 나오게 하려고 전달한거에요~