#110 fix : 헤더 진행률 & 알람 종류 추가 #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyungJiwoo
reviewed
Nov 12, 2024
Comment on lines
+23
to
+25
| <S.GraphProgress blockProgress={progress.toFixed(1)}></S.GraphProgress> | ||
| </S.GraphWrapper> | ||
| <span>{blockProgress}%</span> | ||
| <span>{progress.toFixed(1)}%</span> |
There was a problem hiding this comment.
파라미터로 1은 왜 전달하는지 궁금합니다!~
There was a problem hiding this comment.
아 저게 소수점 밑에 1자리 수로 나오게 하려고 전달한거에요~
MyungJiwoo
reviewed
Nov 12, 2024
Comment on lines
+139
to
+167
| //시작점 상태에서 종착지가 시작점 상태와는 다른 상태일때 그 아이템 개수 -1 | ||
| if (source.droppableId === 'todo' && destination.droppableId !== 'todo') | ||
| setBlockTotal(prev => ({ | ||
| ...prev, | ||
| todo: blockTotal.todo - 1, | ||
| [destination.droppableId]: | ||
| blockTotal[destination.droppableId as keyof typeof blockTotal] + 1, | ||
| })); | ||
| else if (source.droppableId === 'doing' && destination.droppableId !== 'doing') | ||
| setBlockTotal(prev => ({ | ||
| ...prev, | ||
| doing: blockTotal.doing - 1, | ||
| [destination.droppableId]: | ||
| blockTotal[destination.droppableId as keyof typeof blockTotal] + 1, | ||
| })); | ||
| else if (source.droppableId === 'completed' && destination.droppableId !== 'completed') | ||
| setBlockTotal(prev => ({ | ||
| ...prev, | ||
| completed: blockTotal.completed - 1, | ||
| [destination.droppableId]: | ||
| blockTotal[destination.droppableId as keyof typeof blockTotal] + 1, | ||
| })); | ||
| else if (source.droppableId === 'delete' && destination.droppableId !== 'delete') | ||
| setBlockTotal(prev => ({ | ||
| ...prev, | ||
| delete: blockTotal.completed - 1, | ||
| [destination.droppableId]: | ||
| blockTotal[destination.droppableId as keyof typeof blockTotal] + 1, | ||
| })); |
There was a problem hiding this comment.
function updateBlockTotal(sourceId: string, destinationId: string) {
if (sourceId !== destinationId) {
setBlockTotal(prev => ({
...prev,
[sourceId]: blockTotal[sourceId as keyof typeof blockTotal] - 1,
[destinationId]: blockTotal[destinationId as keyof typeof blockTotal] + 1,
}));
}
}
// 호출 부분
updateBlockTotal(source.droppableId, destination.droppableId);
위와 같이 중복되는 부분을 함수로 분리하면 더 간결하게 작성할 수 있을 것 같아요!
There was a problem hiding this comment.
조언 감사합니다!
추후에 수정할게요!
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🪄 목적
💻 상세 작업 내용
📸 스크린샷
👼🏻 리뷰 요구사항 (선택)