Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding python3.7 docker. Chmod +x macq/*install #85

Merged
merged 1 commit into from
Jun 17, 2022

Conversation

hectorpal
Copy link
Contributor

Fixes #84
Following https://stackoverflow.com/questions/56892907/install-pip3-and-python3-7-on-docker-ubuntu-18-04

Why like this?

@hectorpal
Copy link
Contributor Author

@haz the test just passed but this is not working yet.

I guess it's not testing buidling the docker image. Not sure that's possible in your setup.

@hectorpal hectorpal marked this pull request as ready for review June 11, 2022 22:58
@hectorpal
Copy link
Contributor Author

I think it's ready now.
What's your workflow for testing the docker image?

I modify it in this way:

...
# Install & setup the planutils
WORKDIR /root
COPY . .
RUN pip3 install -e . --trusted-host pypi.org --trusted-host files.pythonhosted.org
RUN planutils setup


# default command to execute when container starts
CMD /bin/bash

@haz
Copy link
Contributor

haz commented Jun 13, 2022

Thanks @hectorpal ! I'm now second guessing why we'd want a 4-year old base, though.

@FlorianPommerening : I know I've asked before, but didn't you say the modern Ubuntu had a modern-enough Singularity to be viable for our planners? I.e., could we get away with just using Ubuntu 22.04 and installing Singularity from apt?

@FlorianPommerening
Copy link
Collaborator

I didn't try this yet, but Singularity rebranded and now is called Apptainer (http://apptainer.org/). They seem to have *.deb releases (https://github.com/apptainer/apptainer/releases) which would probably work.

@haz
Copy link
Contributor

haz commented Jun 13, 2022

I won't have a chance until tomorrow, but my plan of attack (if you have the cycles, @hectorpal ) would be:

  1. Run a vanilla 22.04 docker image
  2. Install python/pip/etc.
  3. See if you can get apptainer installed
  4. pip3 install planutils
  5. Give a planner a shot.

May need --privileged running, but for testing, just a personal comp would do.

@FlorianPommerening
Copy link
Collaborator

This Dockerfile works fine for me (changed ubuntu to 22.04 and singularity to apptainer installed from deb). It still needs --privileged when running docker but running planutils install lama && planutils run lama in the container works.

FROM ubuntu:22.04

LABEL maintainer="Christian Muise ([email protected])"

# Install required packages
RUN apt-get update \
    && DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y \
        bash-completion \
        ca-certificates \
        git \
        libseccomp-dev \
        python3 \
        python3-pip \
        python3-venv \
        squashfs-tools \
        tzdata \
        unzip \
        vim \
        wget \
    && rm -rf /var/lib/apt/lists/*

RUN wget https://github.com/apptainer/apptainer/releases/download/v1.0.2/apptainer_1.0.2_amd64.deb \
    && dpkg -i apptainer_1.0.2_amd64.deb \
    && rm apptainer_1.0.2_amd64.deb

RUN pip3 install --upgrade pip
RUN pip3 install setuptools

# Install & setup the planutils
RUN pip3 install planutils --trusted-host pypi.org --trusted-host files.pythonhosted.org
RUN planutils setup

WORKDIR /root

# default command to execute when container starts
CMD /bin/bash

@hectorpal
Copy link
Contributor Author

I guess the singularity-based should work, so it's a matter of testing the binaries.

I didn't see automation tooling for testing the planners are still running. Maybe it's not worth it.

Maybe non-singularity package tools should add a basic test: VAL, FF.

@haz
Copy link
Contributor

haz commented Jun 15, 2022

Awesome stuff! Things seem to work just fine with it.

@hectorpal Want to merge from main, and then ping again? AFAIK, just the permissions need updating now.

- Building was failing installing python-sat.
  - I tried a couple of smaller alternatives but python3 did the job.
- Fixed permissions
Dockerfile Show resolved Hide resolved
@haz haz merged commit 342c023 into AI-Planning:main Jun 17, 2022
@hectorpal hectorpal deleted the hp/fix-macq branch June 17, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Macq is not installing
3 participants