Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: singularity dependency for detecing that singularity-based planners can run #79

Open
3 tasks
hectorpal opened this issue Jun 3, 2022 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed package New package request or fix

Comments

@hectorpal
Copy link
Contributor

hectorpal commented Jun 3, 2022

Context

  • Some users might want to use planutils in Docker but with no privileged access
  • Right now, only a few packages works, including VAL and pyperplan

Definition of done

  • Installing "singularity" package check if singularity planners can run, reporting the need for privileged access
  • Installing planners that use singularity would fail right away if
  • Documentation specifies that singularity is needed for most plans, and that installing them fails quickly

Implementation idea

  • “singularity” install pulls a tiny singularity image and attempt to run it
  • first installation attempt use some bandwidth
  • new calls would be faster because image is in singularity cache

Checklist

  • Should check to see if it's installed and has the right version/privileges required to run the planners that need it.
  • Warn the user (fail to install) if it's not setup right
  • Planners that use singularity should have this package as a dependency
@haz haz mentioned this issue Jun 3, 2022
3 tasks
@haz haz added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed package New package request or fix labels Jun 3, 2022
@hectorpal hectorpal changed the title Request: new package for detecing that singularity can run Request: singulary dependency for detecing that singularity-based planners can run Jun 9, 2022
@hectorpal hectorpal changed the title Request: singulary dependency for detecing that singularity-based planners can run Request: singularity dependency for detecing that singularity-based planners can run Jun 9, 2022
@hectorpal
Copy link
Contributor Author

hectorpal commented Jun 17, 2022

This might lead to a different issue.

Following the discussion at #85
What if we had a dependency for "compile" that can only be installed when creating the docker image?

For instance,

  • "compile" install the ubuntu packages added so MACQ compiles.
  • Then we ask MACQ to have such dependency.

Alternative:

  • Recommend people to package binaries outside and provide a base Dockerfile for that. That's basically a Dockerfile including the current Docker and adding some packages as suggestion.

@haz
Copy link
Contributor

haz commented Jun 17, 2022

Not sure I follow the suggestions...I think this suggestion is more useful now that installing singularity is easier on modern systems. No longer requires Go and rebuilding the entire project.

@hectorpal
Copy link
Contributor Author

I tried to make it more clear

@haz
Copy link
Contributor

haz commented Jun 17, 2022

You mean for this issue? I think having singularity is now a very real possibility for average users on modern Ubuntu OS'. So having this as a package makes sense. We wouldn't need to "compile" singularity to get it going anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed package New package request or fix
Projects
None yet
Development

No branches or pull requests

2 participants