Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add grain removal based on height (identify and isolate scars) #154

Closed
SylviaWhittle opened this issue May 19, 2022 · 6 comments · Fixed by #390
Closed

Add grain removal based on height (identify and isolate scars) #154

SylviaWhittle opened this issue May 19, 2022 · 6 comments · Fixed by #390
Assignees
Labels
enhancement New feature or request

Comments

@SylviaWhittle
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Removing anomalously high-up grains would be useful as it would remove artefacts such as scars and blobs that are not wanted and would mess with the scaling of the data.

Describe the solution you'd like
A system that detects grains that are 2 standard deviations from the mean grain height and removes them.

@SylviaWhittle SylviaWhittle added the enhancement New feature or request label May 19, 2022
@SylviaWhittle SylviaWhittle self-assigned this May 19, 2022
@SylviaWhittle
Copy link
Collaborator Author

This maybe should go in filters as it could help with flattening

@SylviaWhittle
Copy link
Collaborator Author

Focus on scars as opposed to blobs

@SylviaWhittle SylviaWhittle changed the title TopoStats 2.0 : Add grain removal based on height Add grain removal based on height Sep 27, 2022
@bobturneruk
Copy link
Member

@bobturneruk
Copy link
Member

Image contain ~1px wide really high streaks (horizontal) - called scars. Mess up image processing and data. Need to identify and locate these features and flag them to remove if we want to. And to be able to ignore these from the flattening and grain finding process. The way forwards might be to mask out scars early on in the analysis pipeline. Maybe a separate scar mask might be good.

@bobturneruk bobturneruk changed the title Add grain removal based on height Add grain removal based on height (identify and isolate scars) Oct 3, 2022
@ns-rse
Copy link
Collaborator

ns-rse commented Oct 3, 2022

I don't know if this would be of use but I realised I had previously created #202 because I'd stumbled across the Hough Transform which is a method for identifying classes of shapes, classically straight-lines, from images.

There are methods in scikit-image that implement this (see #202 for links).

@alicepyne
Copy link
Member

alicepyne commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants