ArangoJS 10 #347
Open
ArangoJS 10 #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArangoJS 10 no longer supports Node 18, and it will be EOL soon.
Removes the "arangojs instrumentation" code, which was a copy of the core request processing classes of arangojs. The update to arangojs 10 would have required major changes to these files, and they were a code quality problem anyway. Instead of our custom patches, we now rely on beforeRequest and afterResponse. They can be specified once per Database, which is not sufficient for our use case, so we currently call request() directly instead of the proper executeTransaction(). Hopefully, arangojs will add a way to specify these hooks in executeTransaction() as well. See arangodb/arangojs#817 for the feature request. BREAKING CHANGE: arangojs 8 is no longer supported. Update to arangojs 10. BREAKING CHANGE: ArangoJSConfig is no longer exported. Import ConfigOptions from arangojs/configuration directly if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.