Skip to content

Commit

Permalink
feat: update to arangojs 10
Browse files Browse the repository at this point in the history
Removes the "arangojs instrumentation" code, which was a copy of the core
request processing classes of arangojs. The update to arangojs 10 would
have required major changes to these files, and they were a code quality
problem anyway.

Instead of our custom patches, we now rely on beforeRequest and
afterResponse. They can be specified once per Database, which is not
sufficient for our use case, so we currently call request() directly
instead of the proper executeTransaction(). Hopefully, arangojs will add
a way to specify these hooks in executeTransaction() as well. See
arangodb/arangojs#817 for the feature request.

BREAKING CHANGE: arangojs 8 is no longer supported. Update to arangojs 10.

BREAKING CHANGE: ArangoJSConfig is no longer exported. Import ConfigOptions
from arangojs/configuration directly if needed.
  • Loading branch information
Yogu committed Jan 8, 2025
1 parent ba5a0fb commit 7959f21
Show file tree
Hide file tree
Showing 22 changed files with 206 additions and 916 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Install [ArangoDB](https://www.arangodb.com/) and create a new database.
import { ArangoDBAdapter } from 'cruddl';
const db = new ArangoDBAdapter({
databaseName: 'databaseName',
url: 'http://root:@localhost:8529',
url: 'http://localhost:8529',
user: 'root',
password: '',
});
Expand Down
2 changes: 1 addition & 1 deletion example/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { ApolloServer } from 'apollo-server';
// arangodb --starter.local --starter.mode=single --starter.port=8529
const db = new ArangoDBAdapter({
databaseName: 'test',
url: 'http+tcp://root:@localhost:8529',
url: 'http://localhost:8529',
user: 'root',
password: '',
});
Expand Down
Loading

0 comments on commit 7959f21

Please sign in to comment.