Require explicit channel type negotiation #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
explicit-channel-type
branch
from
2761346
to
504ff2a
Compare
t-bast
force-pushed
the
explicit-channel-type
branch
from
504ff2a
to
feb12ef
Compare
t-bast
force-pushed
the
explicit-channel-type
branch
from
feb12ef
to
1542d72
Compare
t-bast
force-pushed
the
explicit-channel-type
branch
2 times, most recently
from
0b51884
to
4924629
Compare
t-bast
force-pushed
the
explicit-channel-type
branch
2 times, most recently
from
0a9125d
to
9236c53
Compare
t-bast
force-pushed
the
explicit-channel-type
branch
from
9236c53
to
7554588
Compare
And move commands to a new ChannelCommands file. This commit doesn't contain any logic changes.
This feature was introduced by lightning/bolts#880 and the feature bit was added in lightning/bolts#906 We also clean up the channel state machine to leverage the feature bits added in #237
t-bast
force-pushed
the
explicit-channel-type
branch
from
7554588
to
713f8c3
Compare
sstone
reviewed
Feb 4, 2022
sstone
approved these changes
Feb 4, 2022
|
Thanks for the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was introduced in the spec by lightning/bolts#880
We take this opportunity to also clean up the channel state machine to leverage the feature bits added in #237 instead of the somewhat hackish reliance on
isZeroReservefor a bunch of unrelated Phoenix features.We should only merge this once the ACINQ node has deployed support for ACINQ/eclair#1867 since we will now require explicit channel type negotiation. And we should probably also update our E2E test repository as well to verify that channel opening works correctly.