More flexible mutual close fees #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-bast
force-pushed
the
closing-fee-range
branch
from
5527281
to
14e7ce9
Compare
t-bast
commented
Apr 28, 2021
| val nextState = this.copy( | ||
| commitments = commitments.copy(remoteChannelData = event.message.channelData), | ||
| closingTxProposed = closingProposed1, | ||
| bestUnpublishedClosingTx = closingTx |
There was a problem hiding this comment.
NB: there was a bug here: we must use signedClosingTx and not closingTx, otherwise we're forgetting our peer's signature 🤕
src/commonMain/kotlin/fr/acinq/lightning/serialization/v1/ChannelState.kt
Show resolved
Hide resolved
t-bast
force-pushed
the
closing-fee-range
branch
from
14e7ce9
to
45a8045
Compare
t-bast
force-pushed
the
closing-fee-range
branch
2 times, most recently
from
6734ec1
to
183aa1a
Compare
t-bast
force-pushed
the
closing-fee-range
branch
4 times, most recently
from
1aacad6
to
d0784ac
Compare
t-bast
force-pushed
the
closing-fee-range
branch
from
d0784ac
to
72bbdef
Compare
Add support for https://github.com/lightningnetwork/lightning-rfc#847 With legacy nodes, we will keep the existing behavior (slowly converge on a fee). But for nodes that support closing fee_ranges, mutual close will take much less round-trips.
t-bast
force-pushed
the
closing-fee-range
branch
from
72bbdef
to
32bccb3
Compare
sstone
approved these changes
Feb 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for https://github.com/lightningnetwork/lightning-rfc#847
With legacy nodes, we will keep the existing behavior (slowly converge on a fee).
But for nodes that support closing
fee_ranges, mutual close will take much less round-trips.This has also been implemented in eclair: ACINQ/eclair#1768
Open question: should we drop support for the old negotiation and greatly simplify that code?
NB: this builds on #277 to leverage the new
ChannelStateversion, and should be included in the same release.