Bladder dorsal ventral #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchristie
requested changes
Feb 12, 2021
Comment on lines
20
to
39
| ("Dorsal part of serosa of urinary bladder", "ILX:0739248"), | ||
| ("Ventral part of serosa of urinary bladder", "ILX:0739249"), | ||
| ("dorsal part of bladder lumen", "None"), | ||
| ("ventral part of bladder lumen", "None"), | ||
| ("dorsal part of serosa of body of urinary bladder", "ILX:0739278"), | ||
| ("ventral part of serosa of body of urinary bladder", "ILX:0739279"), | ||
| ("Dorsal part of lumen of body of urinary bladder", "ILX:0739250"), | ||
| ("Ventral part of lumen of body of urinary bladder", "ILX:0739251"), | ||
| ("dorsal part of serosa of neck of urinary bladder", "ILX:0739280"), | ||
| ("ventral part of serosa of neck of urinary bladder", "ILX:0739281"), | ||
| ("Dorsal part of lumen of neck of urinary bladder", "ILX:0739255"), | ||
| ("Ventral part of lumen of neck of urinary bladder", "ILX:0739257"), | ||
| ("dorsal part of serosa of urethra", "ILX:0739283"), | ||
| ("ventral part of serosa of urethra", "ILX:0739306"), | ||
| ("Dorsal part of lumen of urethra", "ILX:0739260"), | ||
| ("Ventral part of lumen of urethra", "ILX:0739261"), | ||
| ("dorsal part of the bladder", "None"), | ||
| ("ventral part of the bladder", "None"), | ||
| ("Dorsal part of urethra", "ILX:0739258"), | ||
| ("Ventral part of urethra", "ILX:0739259"), |
There was a problem hiding this comment.
Put all terms in alphabetical order (case insensitive).
The mix of upper and lower case is annoying; I suggest you change all to lower case as I've made scaffoldmaker match data groups differing by case and whitespace only (and it renames the data group to exactly match).
Comment on lines
40
to
41
| ("dorsal part of the scaffold", "None"), | ||
| ("ventral part of the scaffold", "None") |
There was a problem hiding this comment.
Remove these; not specific to an organ.
Find a way to do without them.
rchristie
requested changes
Feb 22, 2021
| ("ventral part of serosa of neck of urinary bladder", "ILX:0739281"), | ||
| ("ventral part of serosa of urethra", "ILX:0739306"), | ||
| ("ventral part of serosa of urinary bladder", "ILX:0739249"), | ||
| ("ventral part of the bladder", "None"), |
| ("dorsal part of lumen of body of urinary bladder", "ILX:0739250"), | ||
| ("dorsal part of lumen of neck of urinary bladder", "ILX:0739255"), | ||
| ("dorsal part of lumen of urethra", "ILX:0739260"), | ||
| ("dorsal part of the bladder", "None"), |
There was a problem hiding this comment.
Rename to remove "the" --> "dorsal part of bladder" for consistency with other terms.
Also "ventral part of bladder" below.
(Exception: "dome of the bladder" is already in SciCrunch with "the", so can't change it).
There was a problem hiding this comment.
Also update where they are used?
rchristie
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dorsal, ventral annotations and marker point were added to the bladderurethra1.py.