libsecret: Keys() unlocks collection first #61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 99designs/aws-vault#513
This patch makes
secretsKeyring.Keys()
unlock a locked collection before getting its items and their labels. Otherwise, it returns a list of empty strings.I spent quite a while trying to write a test for it, but testing over live D-Bus with locking and caching(?) proved beyond me. Instead I've verified it from ./cmd/keyring: