99designs/keyring v1.1.4; fix linux / secret-service bug #521
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #513
1c0b58a from #481 released in v5.1.0, as part of a substantial overhaul, introduced a
keyring.Has(key)
check where previously it just hoped for the best and the aws-sdk ended up attempting toKeyring.Get(key)
as part of the credential provider. In thesecret-service
backend (linux / libsecret / gnome keyring),Get
was unlocking the item as needed, butHas
was not unlocking the items/collection; instead it would return empty strings for a locked collection.99designs/keyring#61 fixes the upstream
Keyring.Has()
bug, and this patch brings the resulting v1.1.4 release into aws-vault.This go.mod & go.sum update is the result of:
Manual testing: