Always wrap user errors #1312
Merged
Always wrap user errors #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwc
force-pushed
the
error-wrapping
branch
2 times, most recently
from
450dc9a to
e024656
Compare
mtibben
approved these changes
Sep 3, 2020
There was a problem hiding this comment.
Yes this looks like a superior approach to me comparing to #1305
Are we comfortable with supporting 1.13 and up?
+1 from me. Personally I think supporting the just last 2 versions of Go is totally justifiable, Go has high focus on backwards compatibility and if you really want to use an older go, you can use an older gqlgen release too
Should we change the signature of ErrorPresenterFunc to func(ctx context.Context, err *gqlerror.Error) *gqlerror.Error?
Yes I think so. Lets make the BC break obvious
This is an alternative to #1305 that leans into error wrapping instead of away from it. Requires use of go 1.13 error unwrapping. On measure I think I prefer this approach, even though it's a bigger BC break: - There's less mutex juggling - It has never felt right to me that we make the user deal with path when overriding the error presenter - The default error presenter is now incredibly simple Questions: - Are we comfortable with supporting 1.13 and up? - Should we change the signature of `ErrorPresenterFunc` to `func(ctx context.Context, err *gqlerror.Error) *gqlerror.Error`? - It always is now, and breaking BC will force users to address the requirement for `errors.As`
cgxxv
pushed a commit
to cgxxv/gqlgen
that referenced
this pull request
Mar 25, 2022
Always wrap user errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #1305 that leans into error wrapping instead of away from it.
Requires use of go 1.13 error unwrapping.
On measure I think I prefer this approach, even though it's a bigger BC break:
Questions:
ErrorPresenterFunctofunc(ctx context.Context, err *gqlerror.Error) *gqlerror.Error?errors.AsFixes: #1291
I have: