INPUT_FIELD_DEFINITION directive handler returned errors are clobbered

[dixieflatline76]

What happened?

When using an INPUT_FIELD_DEFINITION directive, if the implemented directive handler returns a custom error (meant for leveraging custom error presenter to deliver tailored error graph style and info), it is overwritten with a gqlerror with only the error string copied over. This is a break introduced in v0.12.x, same code runs fine in v0.11.x and v0.10.x.

What did you expect?

Errors returned in any directive handlers should be propagated without lost of information until the custom error presenters are run.

Minimal graphql.schema and models to reproduce

directive @titleField(fieldName: String) on INPUT_FIELD_DEFINITION
directive @genresField(fieldName: String) on INPUT_FIELD_DEFINITION

input NewGame {
title: String! @titleField # Add directive to input type field to pattern validation and string case normalization
genres: [Genre!]! @genresField(fieldName:"genres") # Refer to demoserver.go to see we check for min 1 and max of 2 genres, and they must be unique
platforms: [NewGamePlatform!]!
}

versions

• gqlgen version v0.12.1
• go version? 1.14.2
• dep or go modules?

[lwc]

@dixieflatline76 can you confirm that v0.13.0 fixes this for you, after swapping from type assertions to errors.As?

[dixieflatline76]

@lwc thanks, I will test this out.

[dixieflatline76]

@lwc just curious, looks like the default error handler just does a hard cast no test on the incoming error (i noticed it cause it crashed one of my unit tests). Wouldn't it be better to either just change the signature graphql.ErrorPresenterFunc and the default error presenter to accept a gqlerror?

[dixieflatline76]

@dixieflatline76 can you confirm that v0.13.0 fixes this for you, after swapping from type assertions to errors.As?

@lwc I can confirm that the issue I reported is fixed with v0.13.0. Thank you!