Merge pull request #192 from vektah/strict-config

Strict config
99designs · Jul 14, 2018 · f478f81 · f478f81
2 parents 533dcba + a1c02e7
commit f478f81
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/codegen/config.go b/codegen/config.go
@@ -46,7 +46,7 @@ func LoadConfig(filename string) (*Config, error) {
 		return nil, errors.Wrap(err, "unable to read config")
 	}
 
-	if err := yaml.Unmarshal(b, &config); err != nil {
+	if err := yaml.UnmarshalStrict(b, &config); err != nil {
 		return nil, errors.Wrap(err, "unable to parse config")
 	}
 

diff --git a/codegen/config_test.go b/codegen/config_test.go
@@ -20,6 +20,11 @@ func TestLoadConfig(t *testing.T) {
 		_, err := LoadConfig("testdata/cfg/malformedconfig.yml")
 		require.EqualError(t, err, "unable to parse config: yaml: unmarshal errors:\n  line 1: cannot unmarshal !!str `asdf` into codegen.Config")
 	})
+
+	t.Run("unknown keys", func(t *testing.T) {
+		_, err := LoadConfig("testdata/cfg/unknownkeys.yml")
+		require.EqualError(t, err, "unable to parse config: yaml: unmarshal errors:\n  line 2: field unknown not found in type codegen.Config")
+	})
 }
 
 func TestLoadDefaultConfig(t *testing.T) {

diff --git a/codegen/testdata/cfg/unknownkeys.yml b/codegen/testdata/cfg/unknownkeys.yml
@@ -0,0 +1,2 @@
+schema: outer
+unknown: foo