Merge pull request #191 from vektah/nullable-list-elements

Support nullable list elements

codegen/type_build.go

@@ -80,7 +80,7 @@ func (n NamedTypes) getType(t common.Type) *Type {
 		if _, nonNull := t.(*common.NonNull); nonNull {
 			usePtr = false
 		} else if _, nonNull := t.(*common.List); nonNull {
-			usePtr = false
+			usePtr = true
 		} else {
 			if usePtr {
 				modifiers = append(modifiers, modPtr)

example/dataloader/schema.graphql

@@ -2,7 +2,7 @@ type Query {
     customers: [Customer!]
 
     # this method is here to test code generation of nested arrays
-    torture(customerIds: [[Int]]): [[Customer!]]
+    torture(customerIds: [[Int!]]): [[Customer!]]
 }
 
 type Customer {

example/selection/schema.graphql

@@ -18,7 +18,7 @@ type Like implements Event {
 }
 
 type Query {
-    events: [Event]
+    events: [Event!]
 }
 
 scalar Time

example/starwars/schema.graphql

@@ -1,8 +1,8 @@
 # The query type, represents all of the entry points into our object graph
 type Query {
     hero(episode: Episode = NEWHOPE): Character
-    reviews(episode: Episode!, since: Time): [Review]!
-    search(text: String!): [SearchResult]!
+    reviews(episode: Episode!, since: Time): [Review!]!
+    search(text: String!): [SearchResult!]!
     character(id: ID!): Character
     droid(id: ID!): Droid
     human(id: ID!): Human
@@ -28,7 +28,7 @@ interface Character {
     # The name of the character
     name: String!
     # The friends of the character, or an empty list if they have none
-    friends: [Character]
+    friends: [Character!]
     # The friends of the character exposed as a connection with edges
     friendsConnection(first: Int, after: ID): FriendsConnection!
     # The movies this character appears in
@@ -52,13 +52,13 @@ type Human implements Character {
     # Mass in kilograms, or null if unknown
     mass: Float
     # This human's friends, or an empty list if they have none
-    friends: [Character]
+    friends: [Character!]
     # The friends of the human exposed as a connection with edges
     friendsConnection(first: Int, after: ID): FriendsConnection!
     # The movies this human appears in
     appearsIn: [Episode!]!
     # A list of starships this person has piloted, or an empty list if none
-    starships: [Starship]
+    starships: [Starship!]
 }
 # An autonomous mechanical character in the Star Wars universe
 type Droid implements Character {
@@ -67,7 +67,7 @@ type Droid implements Character {
     # What others call this droid
     name: String!
     # This droid's friends, or an empty list if they have none
-    friends: [Character]
+    friends: [Character!]
     # The friends of the droid exposed as a connection with edges
     friendsConnection(first: Int, after: ID): FriendsConnection!
     # The movies this droid appears in
@@ -80,9 +80,9 @@ type FriendsConnection {
     # The total number of friends
     totalCount: Int!
     # The edges for each of the character's friends.
-    edges: [FriendsEdge]
+    edges: [FriendsEdge!]
     # A list of the friends, as a convenience when edges are not needed.
-    friends: [Character]
+    friends: [Character!]
     # Information for paginating this connection
     pageInfo: PageInfo!
 }
@@ -125,7 +125,7 @@ type Starship {
     # Length of the starship, along the longest axis
     length(unit: LengthUnit = METER): Float!
     # coordinates tracking this ship
-    history: [[Int]]
+    history: [[Int!]!]!
 }
 union SearchResult = Human | Droid | Starship
 scalar Time

test/resolvers_test.go

@@ -127,8 +127,8 @@ func (r *testResolvers) Query_date(ctx context.Context, filter models.DateFilter
 	return r.queryDate(ctx, filter)
 }
 
-func (r *testResolvers) Query_path(ctx context.Context) ([]models.Element, error) {
-	return []models.Element{{1}, {2}, {3}, {4}}, nil
+func (r *testResolvers) Query_path(ctx context.Context) ([]*models.Element, error) {
+	return []*models.Element{{1}, {2}, {3}, {4}}, nil
 }
 
 func (r *testResolvers) Element_child(ctx context.Context, obj *models.Element) (models.Element, error) {