Add --stdout option to aws-vault exec
#819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe the cli option should be |
lsowen
force-pushed
the
add-no-browser
branch
from
d0cf5b5
to
11f3dcc
Compare
m4yankpomelo
approved these changes
Oct 18, 2021
|
hi @m4yankpomelo it looks like Github is still waiting on some action from a maintainer for "1 workflow"? |
Accidentally approved, apologies :) |
|
@lsowen could you merge it? |
|
No, it needs review and approval by a project member |
|
hi @mtibben do you have any availability to review this PR? |
|
@lsowen I think it would be best to make this consistent with |
lsowen
force-pushed
the
add-no-browser
branch
from
11f3dcc
to
eaa7c67
Compare
By default `aws-vault` opens the the AWS SSO link in the user's default browser, but specifying `--stdout` will only print the AWS SSO link to the terminal, allowing the user to open the link in a non-default way (eg firefox profile, on a different machine, etc)
lsowen
force-pushed
the
add-no-browser
branch
from
eaa7c67
to
b3a9a23
Compare
lsowen
changed the title
--no-browser option to aws-vault exec--stdout option to aws-vault exec
|
@mtibben updated the PR from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default
aws-vaultopens the the AWS SSO link in the user'sdefault browser, but specifying
--no-browserwill only printthe AWS SSO link to the terminal, allowing the user to open
the link in a non-default way (eg firefox profile, on a different
machine, etc)
Fixes #678