Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: AWS SSO "--no-browser" option #678

Closed
lsowen opened this issue Oct 21, 2020 · 6 comments · Fixed by #819
Closed

Feature: AWS SSO "--no-browser" option #678

lsowen opened this issue Oct 21, 2020 · 6 comments · Fixed by #819
Labels

Comments

@lsowen
Copy link
Contributor

lsowen commented Oct 21, 2020

For various reasons such as not wanting to use the system default browser, wanting to open the SSO link in a specific Firefox Containers container, etc, it would be useful to be able to optionally only print the VerificationUriComplete instead of only showing it if open.Run() fails. My suggestion would be to add a new --no-browser or similar option that could be used to trigger this behaviour (with the default being the current widely useful "auto-open" method).

Once the link is opened once, it cannot be re-used, so currently there is no way to grab the link before it has been used the first time (unless the default URL handling browser fails to open or is missing)

fmt.Fprintf(os.Stderr, "Opening the SSO authorization page in your default browser (use Ctrl-C to abort)\n%s\n", aws.StringValue(deviceCreds.VerificationUriComplete))
if err := open.Run(aws.StringValue(deviceCreds.VerificationUriComplete)); err != nil {
log.Printf("Failed to open browser: %s", err)
}

@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 11, 2021
@olfway
Copy link
Contributor

olfway commented Jun 11, 2021

It's not stale

@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 3, 2022
@lsowen
Copy link
Contributor Author

lsowen commented Jan 3, 2022

Not stale

@stale stale bot removed the stale label Jan 3, 2022
@turiandras
Copy link

did anyone find a good workaround?
for the 'aws' cli, setting BROWSER to /usr/bin/echo is supposedly a good solution ( aws/aws-cli#5301 ), doesnt seem to work for 'aws-vault'

@turiandras
Copy link

Ok apparently the "--stdout" flag now does exactly this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants